Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-116420: Fix unused var compilation warnings #116466

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Mar 7, 2024

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not rename the variables in the op header to unused? It generates less code and is more efficient.

@Fidget-Spinner
Copy link
Member Author

In general we want the instruction definition header to be the same stack effect as the original bytecode IMO

@Fidget-Spinner Fidget-Spinner merged commit 4298d69 into python:main Mar 7, 2024
54 checks passed
@Fidget-Spinner Fidget-Spinner deleted the void_compare_ops branch March 7, 2024 16:20
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning: "variable ‘right’ set but not used" in optimizer_cases.c.h
2 participants