gh-112075: Support freeing object memory via QSBR #116344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DinoV
force-pushed
the
nogil_dict_obj_qsbr
branch
from
1023064
to
d764284
Compare
colesbury
reviewed
Mar 5, 2024
DinoV
changed the title
DinoV
force-pushed
the
nogil_dict_obj_qsbr
branch
from
d764284
to
faa4484
Compare
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
Free objects with qsbr if shared
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
Free objects with qsbr if shared
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for freeing GC objects with QSBR. This will enable objects with in-lined values to be freed.
Currently this is just freeing any object that gets shared as being freed by QSBR. We may want to break this into 2 bits so that when we mark a dict or a list as shared that the underlying object gets freed and only the values get delayed.
dictobjects thread-safe in--disable-gilbuilds #112075