Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-112075: Support freeing object memory via QSBR #116344

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

DinoV
Copy link
Contributor

@DinoV DinoV commented Mar 5, 2024

Adds support for freeing GC objects with QSBR. This will enable objects with in-lined values to be freed.

Currently this is just freeing any object that gets shared as being freed by QSBR. We may want to break this into 2 bits so that when we mark a dict or a list as shared that the underlying object gets freed and only the values get delayed.

Objects/obmalloc.c Outdated Show resolved Hide resolved
Python/gc_free_threading.c Outdated Show resolved Hide resolved
Objects/obmalloc.c Outdated Show resolved Hide resolved
Python/gc_free_threading.c Outdated Show resolved Hide resolved
Objects/obmalloc.c Outdated Show resolved Hide resolved
Python/gc_free_threading.c Show resolved Hide resolved
@DinoV DinoV changed the title gh-112075: Nogil dict obj qsbr gh-112075: Support freeing object memory via QSBR Mar 5, 2024
@DinoV DinoV marked this pull request as ready for review March 6, 2024 15:53
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DinoV DinoV merged commit 7db871e into python:main Mar 8, 2024
35 checks passed
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@DinoV DinoV deleted the nogil_dict_obj_qsbr branch May 31, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants