Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-116313: get WASI builds to run under wasmtime 18 w/ WASI 0.2/preview2 primitives #116327

Merged
merged 4 commits into from
Mar 5, 2024
Merged

GH-116313: get WASI builds to run under wasmtime 18 w/ WASI 0.2/preview2 primitives #116327

merged 4 commits into from
Mar 5, 2024

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Mar 4, 2024 •
edited by bedevere-app bot
Loading

@brettcannon brettcannon self-assigned this Mar 4, 2024
@bedevere-app bedevere-app bot mentioned this pull request Mar 4, 2024
Closed
3 tasks
@erlend-aasland erlend-aasland removed their request for review March 4, 2024 21:10
@brettcannon
Copy link
Member Author

!buildbot wasi

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @brettcannon for commit d0a089d 🤖

The command will test the builders whose names match following regular expression: wasi

The builders matched are:

  • wasm32-wasi Non-Debug PR
  • wasm32 WASI 8Core PR
  • wasm32-wasi PR

@brettcannon
Copy link
Member Author

I think the WASI failures will be fixed by python/buildmaster-config#469 (we were forcibly using the old wasmtime CLI).

@zware
Copy link
Member

zware commented Mar 4, 2024

!buildbot wasi

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @zware for commit d0a089d 🤖

The command will test the builders whose names match following regular expression: wasi

The builders matched are:

  • wasm32-wasi Non-Debug PR
  • wasm32 WASI 8Core PR
  • wasm32-wasi PR

@brettcannon
Copy link
Member Author

!buildbot wasi

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @brettcannon for commit e32099a 🤖

The command will test the builders whose names match following regular expression: wasi

The builders matched are:

  • wasm32-wasi Non-Debug PR
  • wasm32 WASI 8Core PR
  • wasm32-wasi PR

@brettcannon
Copy link
Member Author

I'm going to see if @kushaldas can update his buildbot before I merge this.

@brettcannon brettcannon requested a review from kushaldas March 5, 2024 02:03
@kushaldas
Copy link
Member

!buildbot wasi

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @kushaldas for commit e32099a 🤖

The command will test the builders whose names match following regular expression: wasi

The builders matched are:

  • wasm32-wasi Non-Debug PR
  • wasm32 WASI 8Core PR
  • wasm32-wasi PR

kushaldas
kushaldas approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here.

@kushaldas kushaldas merged commit 7af063d into python:main Mar 5, 2024
46 checks passed
@brettcannon brettcannon deleted the wasi-preview2 branch March 5, 2024 18:26
brettcannon added a commit to brettcannon/cpython that referenced this pull request Mar 5, 2024
@brettcannon
[3.12] pythonGH-116313: get WASI builds to run under wasmtime 18 w/ …
74025a6 
…WASI 0.2/preview2 primitives (pythonGH-116327)
@bedevere-app
Copy link

bedevere-app bot commented Mar 5, 2024

GH-116373 is a backport of this pull request to the 3.12 branch.

brettcannon added a commit that referenced this pull request Mar 5, 2024
@brettcannon
[3.12] GH-116313: get WASI builds to run under wasmtime 18 w/ WASI 0.…
88fdb08 
…2/preview2 primitives (GH-116327) (GH-116373)
brettcannon added a commit that referenced this pull request Mar 5, 2024
@brettcannon
[3.11] GH-116313: get WASI builds to run under wasmtime 18 w/ WASI 0.…
4637a1f 
…2/preview2 primitives (GH-116327) (GH-116373) (GH-116384)

(cherry picked from commit 88fdb08)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@brettcannon @adorilson
pythonGH-116313: get WASI builds to run under wasmtime 18 w/ WASI 0.2…
37f39fa 
…/preview2 primitives (python#116327)

* pythonGH-116313: get WASI builds to run under wasmtime 18 w/ WASI 0.2/preview2 primitives

* Add the configure changes

* Update `wasm_build.py`
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@brettcannon @diegorusso
pythonGH-116313: get WASI builds to run under wasmtime 18 w/ WASI 0.2…
edfb3e8 
…/preview2 primitives (python#116327)

* pythonGH-116313: get WASI builds to run under wasmtime 18 w/ WASI 0.2/preview2 primitives

* Add the configure changes

* Update `wasm_build.py`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushaldas kushaldas kushaldas approved these changes

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees

@brettcannon brettcannon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brettcannon @bedevere-bot @zware @kushaldas