-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-115937: remove extra processing for the __signature__ attribute #115984
Conversation
This is an alternative to python#100168.
((('a', ..., ..., 'positional_or_keyword'), | ||
('b', 2, ..., 'positional_or_keyword')), | ||
...)) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should test that random objects should be passed as-is by the signature function (5, None, []...).
But maybe making this implementation perfect is not urgent as long as a decision has not been made as to what follow-up to bring to the base issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, this is long-standing behavior, but then it needs to be documented. (again, it can wait)
Closing in favour of #116086. Thanks for your interest in improving CPython. |
Obviously, I'm not very good in this:) |
I think you've made a lot of very nice contributions, both code contributions, and as a participant in discussions. Sometimes we disagree, and that's ok. It is also often difficult to get a concensus within the core dev group. That's also ok. |
This is an alternative to #100168.