gh-115881: Ensure ast.parse() parses conditional context managers even with low feature_version passed
#115920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld feature_version (python#94950)" This reverts commit 0daba82.
AlexWaygood
added
type-bug
…s://github.com/AlexWaygood/cpython into parenthesized-context-managers-feature-version
lysnikolaou
approved these changes
Feb 26, 2024
AlexWaygood
deleted the
parenthesized-context-managers-feature-version
branch
|
Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
Sorry, @AlexWaygood, I could not cleanly backport this to |
|
Sorry, @AlexWaygood, I could not cleanly backport this to |
AlexWaygood
added a commit
to AlexWaygood/cpython
that referenced
this pull request
Feb 26, 2024
…gers even with low `feature_version` passed (python#115920)
|
GH-115959 is a backport of this pull request to the 3.12 branch. |
AlexWaygood
added a commit
to AlexWaygood/cpython
that referenced
this pull request
Feb 26, 2024
…gers even with low `feature_version` passed (python#115920)
|
GH-115960 is a backport of this pull request to the 3.11 branch. |
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
…gers even with low `feature_version` passed (python#115920)
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
…gers even with low `feature_version` passed (python#115920)
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…gers even with low `feature_version` passed (python#115920)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ast.parse()believes valid context manager py38 syntax to be invalid whenfeature_version=(3, 8)is passed #115881