Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-113317: Argument Clinic: don't use fail() in CLI #115513

Merged
merged 1 commit into from
Feb 15, 2024
Merged

gh-113317: Argument Clinic: don't use fail() in CLI #115513

merged 1 commit into from
Feb 15, 2024

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Feb 15, 2024 •
edited
Loading

Instead, just raise an exception.

fail() is intended for parser/generator errors, not CLI errors.

@bedevere-app bedevere-app bot mentioned this pull request Feb 15, 2024
Closed
vstinner
vstinner approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erlend-aasland erlend-aasland enabled auto-merge (squash) February 15, 2024 12:00
@erlend-aasland erlend-aasland merged commit 98ee4ec into python:main Feb 15, 2024
43 checks passed
@erlend-aasland erlend-aasland deleted the clinic/use-exceptions-in-cli branch February 15, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@sobolevn sobolevn Awaiting requested review from sobolevn

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erlend-aasland @vstinner