Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-111968: Rename freelist related struct names to Eric's suggestion #115329

Merged
merged 9 commits into from
Feb 14, 2024
Merged

gh-111968: Rename freelist related struct names to Eric's suggestion #115329

merged 9 commits into from
Feb 14, 2024

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Feb 12, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Feb 12, 2024
Closed
@corona10
Copy link
Member Author

#111968 (comment)

split struct _Py_dictkeys_freelist out of struct _Py_dict_freelist

Only one section is left :)

colesbury
colesbury reviewed Feb 12, 2024
View reviewed changes
Include/internal/pycore_freelist.h Outdated Show resolved Hide resolved
Include/internal/pycore_tstate.h Outdated Show resolved Hide resolved
@corona10
Copy link
Member Author

CI failure is unrelated to this PR: see #115383

ericsnowcurrently
ericsnowcurrently approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

colesbury
colesbury approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too!

@corona10 corona10 enabled auto-merge (squash) February 14, 2024 00:12
@corona10 corona10 merged commit f15795c into python:main Feb 14, 2024
34 checks passed
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@corona10 @fsc-eriker
pythongh-111968: Rename freelist related struct names to Eric's sugge…
879a8d8 
…stion (pythongh-115329)
@colesbury colesbury mentioned this pull request Feb 14, 2024
Closed
@corona10 corona10 deleted the gh-111968-struct branch February 14, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@colesbury colesbury colesbury approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@methane methane Awaiting requested review from methane methane is a code owner

Assignees
No one assigned
Labels
skip news topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corona10 @colesbury @ericsnowcurrently