gh-115233: Fix an example in the Logging Cookbook #115325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add more tests for LoggerAdapter. Also support stacklevel in LoggerAdapter._log().
serhiy-storchaka
added
tests
vsajip
approved these changes
Feb 12, 2024
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Feb 12, 2024
…nGH-115325) Also add more tests for LoggerAdapter. Also support stacklevel in LoggerAdapter._log(). (cherry picked from commit 9182201) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-115355 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Feb 12, 2024
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 12, 2024
…nGH-115325) (pythonGH-115355) Also add more tests for LoggerAdapter. (cherry picked from commit 225856e) Co-authored-by: Serhiy Storchaka <[email protected]> Also support stacklevel in LoggerAdapter._log(). (cherry picked from commit 9182201)
serhiy-storchaka
pushed a commit
that referenced
this pull request
Feb 12, 2024
…H-115355) (GH-115357) Also add more tests for LoggerAdapter. Also support stacklevel in LoggerAdapter._log(). (cherry picked from commit 225856e) (cherry picked from commit 9182201) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add more tests for LoggerAdapter.
Also support stacklevel in LoggerAdapter._log().
📚 Documentation preview 📚: https://cpython-previews--115325.org.readthedocs.build/