gh-115304: Add doc for initialize PyMutex as global variables #115305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aisk
commented
Feb 11, 2024
•
aisk
commented
- Issue: The typical initialization of PyMutex in its comment document cannot be compiled on Windows #115304
… comment document
aisk
changed the title
aisk
changed the title
colesbury
reviewed
Feb 12, 2024
Include/internal/pycore_lock.h
Outdated
| @@ -26,7 +26,7 @@ extern "C" { | |||
| // 0b11: locked and has parked threads | |||
| // | |||
| // Typical initialization: | |||
| // PyMutex m = (PyMutex){0}; | |||
| // PyMutex m = {0}; | |||
There was a problem hiding this comment.
I don't think we should make this change. The comment is for variables that need explicit initialization, such as local variables and fields in heap allocated structures. Static variables are implicitly initialized to zero in C.
There was a problem hiding this comment.
Maybe instead we can add an additional example of statically initializing the PyMutex?
There was a problem hiding this comment.
Thanks for the review! For local variables, should we remove the cast (PyMutex)? Seems it is needless in modern C.
There was a problem hiding this comment.
Most commonly, we are initializing fields in a struct like:
self->mutex = (PyMutex){0};You can't write:
self->mutex = {0}; // INVALID!
aisk
changed the title
colesbury
reviewed
Feb 20, 2024
Co-authored-by: Sam Gross <[email protected]>
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.