Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-114569: Use PyMem_* APIs for non-PyObjects in Modules/, Objects/ and Parser/ #114574

Merged
merged 5 commits into from
Jan 26, 2024
Merged

gh-114569: Use PyMem_* APIs for non-PyObjects in Modules/, Objects/ and Parser/ #114574

merged 5 commits into from
Jan 26, 2024

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jan 25, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jan 25, 2024
Closed
@erlend-aasland erlend-aasland changed the title gh-114569: Use PyMem_* APIs for non-PyObjects in Modules/ gh-114569: Use PyMem_* APIs for non-PyObjects in Modules/ and Parser/ Jan 25, 2024
colesbury
colesbury approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Erlend, lgtm!

Modules/_elementtree.c Show resolved Hide resolved
@erlend-aasland erlend-aasland enabled auto-merge (squash) January 26, 2024 09:50
@erlend-aasland erlend-aasland enabled auto-merge (squash) January 26, 2024 09:53
@erlend-aasland erlend-aasland changed the title gh-114569: Use PyMem_* APIs for non-PyObjects in Modules/ and Parser/ gh-114569: Use PyMem_* APIs for non-PyObjects in Modules/, Objects/ and Parser/ Jan 26, 2024
@erlend-aasland erlend-aasland merged commit dcd28b5 into python:main Jan 26, 2024
30 checks passed
@erlend-aasland erlend-aasland deleted the nogil/pyobject-malloc branch January 26, 2024 10:11
@erlend-aasland erlend-aasland linked an issue Jan 28, 2024 that may be closed by this pull request
Do not allocate non-PyObjects with PyObject_Malloc() #114569
Closed
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@erlend-aasland @aisk
pythongh-114569: Use PyMem_* APIs for most non-PyObject uses (python#…
04467f2 
…114574)

Fix usage in Modules, Objects, and Parser subdirectories.
@colesbury colesbury mentioned this pull request May 10, 2024
Open
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@erlend-aasland @Glyphack
pythongh-114569: Use PyMem_* APIs for most non-PyObject uses (python#…
16a89a3 
…114574)

Fix usage in Modules, Objects, and Parser subdirectories.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not allocate non-PyObjects with PyObject_Malloc()
2 participants
@erlend-aasland @colesbury