-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing sections to blurbs #114553
Add missing sections to blurbs #114553
Conversation
We should also backport this back to 3.8, so RMs @pablogsal @ambv, is that okay? (This would only be a problem when the next version of blurb is released, and it's not imminently planned.) |
Let just create backport and left the on @pablogsal and @ambv. I think they missed your question, but it will be more difficult to miss PRs. |
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9, 3.10, 3.11, 3.12. |
(cherry picked from commit dc8893a) Co-authored-by: Hugo van Kemenade <[email protected]>
GH-115336 is a backport of this pull request to the 3.12 branch. |
(cherry picked from commit dc8893a) Co-authored-by: Hugo van Kemenade <[email protected]>
GH-115337 is a backport of this pull request to the 3.11 branch. |
(cherry picked from commit dc8893a) Co-authored-by: Hugo van Kemenade <[email protected]>
GH-115338 is a backport of this pull request to the 3.10 branch. |
(cherry picked from commit dc8893a) Co-authored-by: Hugo van Kemenade <[email protected]>
GH-115339 is a backport of this pull request to the 3.9 branch. |
(cherry picked from commit dc8893a) Co-authored-by: Hugo van Kemenade <[email protected]>
GH-115340 is a backport of this pull request to the 3.8 branch. |
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
I am fine doing this for 3.10 and 3.11. @ambv what do you think? |
Add missing sections to blurbs (GH-114553) (cherry picked from commit dc8893a) Co-authored-by: Hugo van Kemenade <[email protected]>
(cherry picked from commit dc8893a) Co-authored-by: Hugo van Kemenade <[email protected]>
Fixes python/core-workflow#525.
After adding more validation to blurb in python/core-workflow#507 (unreleased),
blurb merge
fails for these three files because they're missing a section entry.Other "no new changes" blurbs do contain a
section: Library
entry:We could modify blurb to allow files in
Misc/NEWS.d/next
to skip this validation, but it's easier to add the missing sections.