Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-109653: Speedup import of threading module #114509

Merged
merged 3 commits into from
Jan 31, 2024
Merged

gh-109653: Speedup import of threading module #114509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a73912
Speed up import of threading module
danielhollas Dec 14, 2023
b70b7e5
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 23, 2024
e76cec2
Let's got with lambda instead of functools.partial
danielhollas Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Lib/threading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import os as _os
import sys as _sys
import _thread
import functools
import warnings
import _weakref

Expand Down Expand Up @@ -1630,8 +1629,7 @@ def _register_atexit(func, *arg, **kwargs):
if _SHUTTING_DOWN:
raise RuntimeError("can't register atexit after shutdown")

call = functools.partial(func, *arg, **kwargs)
_threading_atexits.append(call)
_threading_atexits.append(lambda: func(*arg, **kwargs))
ericsnowcurrently marked this conversation as resolved.
Show resolved Hide resolved


from _thread import stack_size
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2024-01-23-23-13-47.gh-issue-109653.KLBHmT.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Reduce the import time of :mod:`threading` module by ~50%. Patch by Daniel Hollas.
Loading