gh-113317: AC converter: Use add_include() in bad_argument()

[vstinner]

Rename also the 'clinic' global variable to 'global_clinic'.

• Issue: Argument Clinic: split out global stateless helpers and constants from clinic.py #113317

[vstinner]

Ah, my simple CConverter.add_include() implementation reached its limits:

  File "/home/runner/work/cpython/cpython/./Tools/clinic/clinic.py", line 3266, in bad_argument
    self.add_include('pycore_modsupport.h', '_PyArg_BadArgument()')
  File "/home/runner/work/cpython/cpython/./Tools/clinic/clinic.py", line 3339, in add_include
    raise ValueError("a converter only supports a single include")
ValueError: a converter only supports a single include

[erlend-aasland]

Ah, my simple CConverter.add_include() implementation reached its limits:

  File "/home/runner/work/cpython/cpython/./Tools/clinic/clinic.py", line 3266, in bad_argument
    self.add_include('pycore_modsupport.h', '_PyArg_BadArgument()')
  File "/home/runner/work/cpython/cpython/./Tools/clinic/clinic.py", line 3339, in add_include
    raise ValueError("a converter only supports a single include")
ValueError: a converter only supports a single include

Yeah, I suspected that :) Well, it should be straight forward to support multiple includes in converters; we could extract the nice "condition" logic you added for Clinic.add_include and reuse that for CConverter.add_include.

[erlend-aasland]

Also, I think the clinic global renaming should be kept out; this PR is likely to grow a little bit.

[vstinner]

Sorry, I should have run tests locally, or mark this PR as a draft. I didn't expect so many back and forth.

All issues should now be fixed (let's see what the CI says).

[erlend-aasland]

I think that can be made an assert.

[vstinner]

Not all converters need a special include. Do you mean that include variable is never None?

[vstinner]

commit e14930f was merged instead, I close my PR.