Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.12] gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359) #114173

Merged
merged 2 commits into from
Jan 21, 2024

Conversation

perrinjerome
Copy link
Contributor

@perrinjerome perrinjerome commented Jan 17, 2024

(cherry picked from commit 04fabe2)

Adjusted for 3.12, because exception printing also happens in C code.

@perrinjerome perrinjerome changed the title gh-113358: Fix rendering tracebacks with exceptions with a broken __g…etattr__ (GH-113359) gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359) Jan 17, 2024
@AlexWaygood AlexWaygood changed the title gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359) [3.12] gh-113358: Fix rendering tracebacks with exceptions with a broken __getattr__ (GH-113359) Jan 17, 2024
… a broken __getattr__ (pythonGH-113359)

(cherry picked from commit 04fabe2)

Co-authored-by: Jérome Perrin <[email protected]>
Co-authored-by: Irit Katriel <[email protected]>
@perrinjerome
Copy link
Contributor Author

@iritkatriel this is for 3.12 ,is it better to use PyErr_GetRaisedException as mentionned on
https://github.com/python/cpython/pull/114118/files#r1455635968 or to keep the same code as for 3.11 ? This version uses the same code as 3.11

@iritkatriel iritkatriel added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jan 20, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 3588252 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jan 20, 2024
@iritkatriel
Copy link
Member

@iritkatriel this is for 3.12 ,is it better to use PyErr_GetRaisedException as mentionned on https://github.com/python/cpython/pull/114118/files#r1455635968 or to keep the same code as for 3.11 ? This version uses the same code as 3.11

We can leave it the same. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants