Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-108852: Add support for Nushell on virtual environment creation #114042

Closed
wants to merge 2 commits into from

Conversation

hyiltiz
Copy link

@hyiltiz hyiltiz commented Jan 13, 2024

Add support for Nushell on virtual environment creation

Script originally contributed by @elferherrera and updated by the community (@melMass @fdncred @tusharsadhwani @kubouch @m-lima @WindSoilder @sophiajt @jimporter) to the Virtualenv project [4].


In light of some recent updates in Nushell development, we may be approaching a time to provide support for Nushell:

  • Nushell users has been in increasing steadily and uses it in personal and work environments as it is quite stable [1].
  • This script is fully tested as part of virtualenv and was stable since May 17, 2023 [2]. During this time, Nushell had 13 minor updates, none of which broke compatility and none required an update to this script [3].

[1] https://www.nushell.sh/blog/2023-11-16-nushell-2023-survey-results.html
[2] pypa/virtualenv#2572
[3] nushell/nushell#9212
[4] https://github.com/pypa/virtualenv/commits/main/src/virtualenv/activation/nushell/activate.nu

Hörmet Yiltiz added 2 commits January 13, 2024 15:33
Signed-off-by: Hörmet Yiltiz <[email protected]>
Signed-off-by: Hörmet Yiltiz <[email protected]>
@hyiltiz hyiltiz requested a review from vsajip as a code owner January 13, 2024 21:10
Copy link

The following commit authors need to sign the Contributor License Agreement:

Click the button to sign:
CLA not signed

@hyiltiz hyiltiz closed this Jan 13, 2024
@hyiltiz hyiltiz deleted the hyiltiz/venv-support-nushell branch January 13, 2024 21:11
@hyiltiz
Copy link
Author

hyiltiz commented Jan 13, 2024

Accidental PR. Please remove if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant