Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-113174: Sync with importlib_metadata 7.0 #113175

Merged
merged 8 commits into from
Dec 21, 2023
Merged

gh-113174: Sync with importlib_metadata 7.0 #113175

merged 8 commits into from
Dec 21, 2023

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Dec 15, 2023 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Dec 15, 2023
Closed
1 task
@hugovk
Copy link
Member

hugovk commented Dec 15, 2023

Sync with importlib_metadata 7.0, including improved type annotations, fixed
issue with symlinked packages in package_distributions, added
EntryPoints.__repr__, introduced the diagnose script, added
Distribution.origin property, and removed deprecated EntryPoint
access by numeric index (tuple behavior).

Will there be docs changes in this PR or another?

@jaraco
Copy link
Member Author

jaraco commented Dec 15, 2023

Will there be docs changes in this PR or another?

I've added docs in b610b6d. I chose not to mention some of the changes as they seemed incidental enough not to affect most users.

@jaraco jaraco marked this pull request as ready for review December 15, 2023 15:13
hugovk
hugovk reviewed Dec 15, 2023
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this also benefit from an entry in What's New in Python 3.13?

Doc/library/importlib.metadata.rst Outdated Show resolved Hide resolved
Doc/library/importlib.metadata.rst Outdated Show resolved Hide resolved
Doc/library/importlib.metadata.rst Outdated Show resolved Hide resolved
@jaraco jaraco force-pushed the feature/113174-importlib-metadata-7.0 branch from 5914c78 to aa23e5a Compare December 15, 2023 16:16
@jaraco
Copy link
Member Author

jaraco commented Dec 15, 2023

Would this also benefit from an entry in What's New in Python 3.13?

Perhaps. I'd consider mentioning the EntryPoint.__getitem__ removal and new Distribution.origin property, though I expect most users not to care much. Overall, I'm thinking it'd be more noise than value, so I'll propose not to add anything, but I'd be happy to add something if anyone feels otherwise.

AlexWaygood
AlexWaygood reviewed Dec 19, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @hugovk that the removal of EntryPoint.__getitem__ should be mentioned in "What's New". It doesn't need to be a prominent mention near the top of the document, but we should try to make sure that all backwards-incompatible changes are mentioned somewhere in that document, in my opinion.

Doc/library/importlib.metadata.rst Outdated Show resolved Hide resolved
@brettcannon brettcannon removed their request for review December 19, 2023 19:18
AlexWaygood
AlexWaygood reviewed Dec 21, 2023
View reviewed changes
Doc/whatsnew/3.13.rst Outdated Show resolved Hide resolved
@jaraco
Copy link
Member Author

jaraco commented Dec 21, 2023

Today I learned about the syntax (docs). The exclamation point means to ignore EntryPoint because it isn't documented.

@jaraco
Copy link
Member Author

jaraco commented Dec 21, 2023

Thanks for the review. Merging, but happy to revisit if needed.

@jaraco jaraco merged commit 2d91409 into python:main Dec 21, 2023
29 checks passed
@jaraco jaraco deleted the feature/113174-importlib-metadata-7.0 branch December 21, 2023 20:04
ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request Dec 26, 2023
@jaraco @AlexWaygood @ryan-duve
pythongh-113174: Sync with importlib_metadata 7.0 (python#113175)
8b200cb 
* Sync with importlib_metadata 7.0.0

* Add blurb

* Update docs to reflect changes.

* Link datamodel docs for object.__getitem__

Co-authored-by: Alex Waygood <[email protected]>

* Add what's new for removed __getattr__

* Link datamodel docs for object.__getitem__

Co-authored-by: Alex Waygood <[email protected]>

* Add exclamation point, as that seems to be used for other classes.

---------

Co-authored-by: Alex Waygood <[email protected]>
@ambv
Copy link
Contributor

ambv commented Jan 2, 2024

There's some tests that are failing on Windows for this change. The build that introduced the failure is the one with this PR merged:
https://buildbot.python.org/all/#/builders/1079/builds/3009

@ambv
Copy link
Contributor

ambv commented Jan 14, 2024

I worked around the problem by enabling SeCreateSymbolicLinkPrivilege for the buildbot user, but ultimately I believe the test should be skipped for users without this privilege set.

kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@jaraco @AlexWaygood @kulikjak
pythongh-113174: Sync with importlib_metadata 7.0 (python#113175)
7700035 
* Sync with importlib_metadata 7.0.0

* Add blurb

* Update docs to reflect changes.

* Link datamodel docs for object.__getitem__

Co-authored-by: Alex Waygood <[email protected]>

* Add what's new for removed __getattr__

* Link datamodel docs for object.__getitem__

Co-authored-by: Alex Waygood <[email protected]>

* Add exclamation point, as that seems to be used for other classes.

---------

Co-authored-by: Alex Waygood <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@jaraco @AlexWaygood @aisk
pythongh-113174: Sync with importlib_metadata 7.0 (python#113175)
8fa3c93 
* Sync with importlib_metadata 7.0.0

* Add blurb

* Update docs to reflect changes.

* Link datamodel docs for object.__getitem__

Co-authored-by: Alex Waygood <[email protected]>

* Add what's new for removed __getattr__

* Link datamodel docs for object.__getitem__

Co-authored-by: Alex Waygood <[email protected]>

* Add exclamation point, as that seems to be used for other classes.

---------

Co-authored-by: Alex Waygood <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@jaraco @AlexWaygood @Glyphack
pythongh-113174: Sync with importlib_metadata 7.0 (python#113175)
6daac7f 
* Sync with importlib_metadata 7.0.0

* Add blurb

* Update docs to reflect changes.

* Link datamodel docs for object.__getitem__

Co-authored-by: Alex Waygood <[email protected]>

* Add what's new for removed __getattr__

* Link datamodel docs for object.__getitem__

Co-authored-by: Alex Waygood <[email protected]>

* Add exclamation point, as that seems to be used for other classes.

---------

Co-authored-by: Alex Waygood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

@hugovk hugovk hugovk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaraco @hugovk @ambv @AlexWaygood