gh-95754: Better AttributeError on partially initialised module #112577
Conversation
hauntsaninja
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
Objects/moduleobject.c
Outdated
| @@ -841,11 +841,22 @@ _Py_module_getattro_impl(PyModuleObject *m, PyObject *name, int suppress) | |||
| } | |||
| if (suppress != 1) { | |||
| if (_PyModuleSpec_IsInitializing(spec)) { | |||
| PyErr_Format(PyExc_AttributeError, | |||
| origin = PyObject_GetAttr(spec, &_Py_ID(origin)); | |||
There was a problem hiding this comment.
PyObject_GetAttr() can set not only AttributeError. If it sets a different error, it should not be overridden by AttributeError.
I suggest to use PyObject_GetOptionalAttr().
There was a problem hiding this comment.
Why not chain the original error to a new exception (raise from)?
There was a problem hiding this comment.
Or maybe this is a use case for adding a note to the original exception and letting it propagate on (if we don't want to change the type of the exception being raised).
|
Thank you for the reviews! |
|
I fixed some errors, please resolve conflicts. |
|
Would be great to mention this nice quality-of-life improvement with an example in What's New, similar to: https://docs.python.org/3/whatsnew/3.12.html#improved-error-messages |
…python#112577) Co-authored-by: Serhiy Storchaka <[email protected]>
…python#112577) Co-authored-by: Serhiy Storchaka <[email protected]>
…python#112577) Co-authored-by: Serhiy Storchaka <[email protected]>
…python#112577) Co-authored-by: Serhiy Storchaka <[email protected]>
Following in the footsteps of: