Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-111965: Use critical sections to make io.BufferedIOBase and its related classes thread safe #112298

Merged
merged 6 commits into from
Nov 22, 2023
Merged

gh-111965: Use critical sections to make io.BufferedIOBase and its related classes thread safe #112298

merged 6 commits into from
Nov 22, 2023

Conversation

Mayuresh16
Copy link
Contributor

@Mayuresh16 Mayuresh16 commented Nov 21, 2023 •
edited by colesbury
Loading

@cpython-cla-bot CPython CLA Bot
Copy link

cpython-cla-bot bot commented Nov 21, 2023 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Nov 21, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Nov 21, 2023
Closed
@Mayuresh16
Copy link
Contributor Author

@colesbury Can you please review this draft PR once to help me to understand the issue if any exists in my work?

colesbury
colesbury reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@colesbury colesbury left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks generally like a reasonable approach.

  • You will need to sign the CLA
  • You should make sure the build passes.

EDIT: Sorry - I see that you've already signed the CLA.

@Mayuresh16
Copy link
Contributor Author

  • You should make sure the build passes.

Yeah, contributing for the first time so had a struggle bit but it was fun to begin and understand build checks too ;)

@Mayuresh16 Mayuresh16 marked this pull request as ready for review November 21, 2023 19:29
colesbury
colesbury approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mayuresh16, this LGTM.

@corona10 corona10 self-assigned this Nov 22, 2023
@corona10 corona10 mentioned this pull request Nov 22, 2023
Closed
corona10
corona10 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, In the end, we should support getter/setter from AC.

@corona10 corona10 merged commit fef6fb8 into python:main Nov 22, 2023
35 checks passed
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@Mayuresh16 @aisk
pythongh-111965: Use critical sections to make io.BufferedIOBase and …
5b9aa3a 
…its related classes thread safe (pythongh-112298)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@Mayuresh16 @Glyphack
pythongh-111965: Use critical sections to make io.BufferedIOBase and …
a345692 
…its related classes thread safe (pythongh-112298)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

@corona10 corona10 corona10 approved these changes

Assignees

@corona10 corona10

Labels
skip news topic-free-threading topic-IO
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mayuresh16 @colesbury @corona10