New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-108303: Move `double_const` to `test_import` where it belongs #112108

Merged

vstinner merged 6 commits into python:main from sobolevn:issue-108303-test_import

Dec 11, 2023

Member

sobolevn commented Nov 15, 2023 •

edited by bedevere-app bot

Loading

I think that initial PR just forgot about it :)

Issue: Move test files into test subdirectories #108303


          pythongh-108303: Move double_const to test_import where it belongs

106c268

sobolevn requested a review from vstinner

November 15, 2023 07:14

sobolevn requested review from brettcannon, ericsnowcurrently, ncoghlan and warsaw as code owners

November 15, 2023 07:14

bedevere-app bot added the awaiting review label

bedevere-app bot mentioned this pull request

Move test files into test subdirectories #108303

Closed

sobolevn added skip news needs backport to 3.11 needs backport to 3.12 labels

vstinner reviewed

View reviewed changes

Lib/test/test_import/__init__.py Outdated Show resolved Hide resolved


          Address review

23319d9

vstinner reviewed

View reviewed changes

Lib/test/test_import/__init__.py Outdated Show resolved Hide resolved


          Simplify import

0af9fb6

brettcannon reviewed

View reviewed changes

Lib/test/test_import/__init__.py Outdated Show resolved Hide resolved

brettcannon previously requested changes

View reviewed changes

Lib/test/test_import/__init__.py Outdated Show resolved Hide resolved

bedevere-app bot added awaiting changes and removed awaiting review labels

bedevere-app bot commented Nov 17, 2023

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.


          Update __init__.py

80be93a

vstinner reviewed

View reviewed changes

Lib/test/test_import/__init__.py Outdated Show resolved Hide resolved

sobolevn added 2 commits

December 2, 2023 13:00


          Address review

6d5b4f7


          Merge branch 'issue-108303-test_import' of https://github.com/sobolev…

962093b

…n/cpython into issue-108303-test_import

Member Author

sobolevn commented Dec 10, 2023

I have made the requested changes; please review again

vstinner approved these changes

View reviewed changes

Member

vstinner left a comment

LGTM

bedevere-app bot added awaiting merge and removed awaiting changes labels

vstinner dismissed brettcannon’s stale review

December 11, 2023 18:29

TEST_HOME_DIR is no longer imported.

vstinner merged commit 0738b9a into python:main

28 of 29 checks passed

miss-islington-app bot commented Dec 11, 2023

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

bedevere-app bot removed the awaiting merge label

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request


          pythongh-108303: Move double_const to test_import where it belongs (

352cb98

pythonGH-112108)

(cherry picked from commit 0738b9a)

Co-authored-by: Nikita Sobolev <[email protected]>

bedevere-app bot commented Dec 11, 2023

GH-112976 is a backport of this pull request to the 3.12 branch.

bedevere-app bot removed the needs backport to 3.12 label

bedevere-app bot commented Dec 11, 2023

GH-112977 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request


          pythongh-108303: Move double_const to test_import where it belongs (

2b7b5d3

pythonGH-112108)

(cherry picked from commit 0738b9a)

Co-authored-by: Nikita Sobolev <[email protected]>

bedevere-app bot removed the needs backport to 3.11 label

vstinner pushed a commit that referenced this pull request


          [3.11] gh-108303: Move double_const to test_import where it belon…

70e50c0

…gs (GH-112108) (#112977)

gh-108303: Move `double_const` to `test_import` where it belongs (GH-112108)
(cherry picked from commit 0738b9a)

Co-authored-by: Nikita Sobolev <[email protected]>

vstinner pushed a commit that referenced this pull request


          [3.12] gh-108303: Move double_const to test_import where it belon…

ac8adf9

…gs (GH-112108) (#112976)

gh-108303: Move `double_const` to `test_import` where it belongs (GH-112108)
(cherry picked from commit 0738b9a)

Co-authored-by: Nikita Sobolev <[email protected]>

aisk pushed a commit to aisk/cpython that referenced this pull request


          pythongh-108303: Move double_const to test_import where it belongs (

e2eb364

python#112108)

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request


          pythongh-108303: Move double_const to test_import where it belongs (

436b567

python#112108)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes

brettcannon brettcannon left review comments

ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

warsaw Awaiting requested review from warsaw warsaw is a code owner

Labels