-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-111906: Remove unused function
warnings during mimalloc build on FREEBSD
#111907
Conversation
furkanonder
commented
Nov 9, 2023
•
edited by bedevere-app
bot
Loading
edited by bedevere-app
bot
- Issue: Unused function warnings during mimalloc build on FREEBSD #111906
cc. @vstinner, who have been interested in FreeBSD builds lately (IIRC). |
!buildbot FreeBSD |
In a recent FreeBSD 14 buildbot build, I see the following compiler warnings:
I scheduled FreeBSD builds to see if the code still builds and if warnings are done. |
With this change, build succeeded on the 3 FreeBSD buildbot jobs:
Moreover, I don't see compiler warnings anymore about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
@DinoV: how can you make these changes upstream? I would prefer to not lose them at the next mimalloc sync. |
Merged. Thanks @furkanonder for your fix. |
You are welcome. |
…n#111907) Fix `unused function` warnings during mimalloc build on FreeBSD.
…n#111907) Fix `unused function` warnings during mimalloc build on FreeBSD.