Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-111906: Remove unused function warnings during mimalloc build on FREEBSD #111907

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

furkanonder
Copy link
Contributor

@furkanonder furkanonder commented Nov 9, 2023

@erlend-aasland
Copy link
Contributor

cc. @vstinner, who have been interested in FreeBSD builds lately (IIRC).

@vstinner
Copy link
Member

!buildbot FreeBSD

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 4717fb0 🤖

The command will test the builders whose names match following regular expression: FreeBSD

The builders matched are:

  • AMD64 FreeBSD14 PR
  • AMD64 FreeBSD15 PR
  • AMD64 FreeBSD PR

@vstinner
Copy link
Member

In a recent FreeBSD 14 buildbot build, I see the following compiler warnings:

Objects/mimalloc/prim/unix/prim.c:66:12: warning: unused function 'mi_prim_open' [-Wunused-function]
Objects/mimalloc/prim/unix/prim.c:69:16: warning: unused function 'mi_prim_read' [-Wunused-function]
Objects/mimalloc/prim/unix/prim.c:72:12: warning: unused function 'mi_prim_close' [-Wunused-function]
Objects/mimalloc/prim/unix/prim.c:75:12: warning: unused function 'mi_prim_access' [-Wunused-function]

I scheduled FreeBSD builds to see if the code still builds and if warnings are done.

@vstinner
Copy link
Member

With this change, build succeeded on the 3 FreeBSD buildbot jobs:

Moreover, I don't see compiler warnings anymore about Objects/mimalloc/. So the change works as expected.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@vstinner
Copy link
Member

@DinoV: how can you make these changes upstream? I would prefer to not lose them at the next mimalloc sync.

@vstinner vstinner merged commit 0ff6368 into python:main Nov 14, 2023
34 checks passed
@vstinner
Copy link
Member

Merged. Thanks @furkanonder for your fix.

@furkanonder
Copy link
Contributor Author

Merged. Thanks @furkanonder for your fix.

You are welcome.

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…n#111907)

Fix `unused function` warnings during mimalloc build on FreeBSD.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…n#111907)

Fix `unused function` warnings during mimalloc build on FreeBSD.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants