Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-90815: Define WITH_MIMALLOC macro in PC/pyconfig.h #111528

Closed
wants to merge 2 commits into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Oct 30, 2023

@vstinner
Copy link
Member Author

Example of a recent PR, test.pythoninfo of Windows x64 says:

build.WITH_MIMALLOC: No

@vstinner
Copy link
Member Author

The build fails on Windows. Example:

obmalloc.obj : error LNK2005: _mi_free already defined in alloc.obj [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

cc @DinoV

@DinoV
Copy link
Contributor

DinoV commented Oct 31, 2023

The build fails on Windows. Example:

obmalloc.obj : error LNK2005: _mi_free already defined in alloc.obj [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

cc @DinoV

I think the issue here is that we're including the files in the Windows build but they're now included via obmalloc.c (this had changed along the way). I'll let the build bots see if #111532 fixes it.

@vstinner
Copy link
Member Author

@DinoV wrote the correct fix: #111532

@vstinner vstinner closed this Oct 31, 2023
@vstinner vstinner deleted the mimalloc_win branch October 31, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants