Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-110572: Remove test_* from _testcapi/getargs.c #111214

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 23, 2023

As it was discussed, all these test now have modern alternatives.
I've also updated test_empty_argparse to check more arguments. Now, there are no test_ prefixed functions left in getargs.c

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also Test_testcapi at the bottom of this file and the corresponding class in test_misc.py. They should be updated.

@sobolevn
Copy link
Member Author

sobolevn commented Oct 23, 2023

Done! I've manually checked that

>>> import _testcapi
>>> [(name, getattr(_testcapi, name))
...                     for name in dir(_testcapi)
...                     if name.startswith('test_') and name.endswith('_code')]
[]

is empty.

@serhiy-storchaka serhiy-storchaka merged commit 4fbf206 into python:main Oct 24, 2023
22 checks passed
@serhiy-storchaka
Copy link
Member

Thanks Nikita.

It would be nice to backport the part of it to 3.12. Only add new functions, without removing old functions.

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants