-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-110572: Remove test_*
from _testcapi/getargs.c
#111214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also Test_testcapi at the bottom of this file and the corresponding class in test_misc.py
. They should be updated.
Done! I've manually checked that >>> import _testcapi
>>> [(name, getattr(_testcapi, name))
... for name in dir(_testcapi)
... if name.startswith('test_') and name.endswith('_code')]
[] is empty. |
Thanks Nikita. It would be nice to backport the part of it to 3.12. Only add new functions, without removing old functions. |
As it was discussed, all these test now have modern alternatives.
I've also updated
test_empty_argparse
to check more arguments. Now, there are notest_
prefixed functions left ingetargs.c
test_*_code
functions in_testcapi/getargs.c
have memory leaks #110572