Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in py312 whatsnew: add missing closing paren #110255

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix typo in py312 whatsnew: add missing closing paren #110255

merged 1 commit into from
Oct 3, 2023

Conversation

lelit
Copy link
Contributor

@lelit lelit commented Oct 3, 2023 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Oct 3, 2023
@lelit
Copy link
Contributor Author

lelit commented Oct 3, 2023

Sorry, I missed the "skip issue" label, maybe the template should mention that in

Most PRs will require an issue number. Trivial changes, like fixing a typo, do not need an issue.

?

@AlexWaygood
Copy link
Member

Sorry, I missed the "skip issue" label, maybe the template should mention that in

Most PRs will require an issue number. Trivial changes, like fixing a typo, do not need an issue.

?

Only triagers and core developers have the power to add that label; you've done nothing wrong :)

AlexWaygood
AlexWaygood approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood AlexWaygood changed the title Fix typo, add missing closing paren in the 3.12 news Fix typo in py312 whatsnew: add missing closing paren Oct 3, 2023
@AlexWaygood AlexWaygood added the needs backport to 3.12 bug and security fixes label Oct 3, 2023
@AlexWaygood AlexWaygood merged commit 8c07137 into python:main Oct 3, 2023
@miss-islington
Copy link
Contributor

Thanks @lelit for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-app
Copy link

bedevere-app bot commented Oct 3, 2023

GH-110257 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2023
@lelit @miss-islington
Fix typo in py312 whatsnew: add missing closing paren (pythonGH-110255)
f366403 
(cherry picked from commit 8c07137)

Co-authored-by: Lele Gaifax <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Oct 3, 2023
@lelit lelit deleted the wn312-typo branch October 3, 2023 06:15
AlexWaygood pushed a commit that referenced this pull request Oct 3, 2023
@miss-islington @lelit
[3.12] Fix typo in py312 whatsnew: add missing closing paren (GH-110255…
64afbf6 
…) (#110257)

Fix typo in py312 whatsnew: add missing closing paren (GH-110255)
(cherry picked from commit 8c07137)

Co-authored-by: Lele Gaifax <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@lelit @Glyphack
Fix typo in py312 whatsnew: add missing closing paren (python#110255)
cd3012c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lelit @AlexWaygood @miss-islington