Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-110119: Temporarily skip test_cppext on --disable-gil builds. #110123

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Sep 29, 2023

The current version of pip does not support "t" in the ABI flags. Skip the test in --disable-gil builds until we can update pip.

The current version of pip does not support "t" in the ABI flags. Skip
the test in `--disable-gil` builds until we can update pip.
@colesbury
Copy link
Contributor Author

!buildbot noGIL

@bedevere-bot
Copy link

The regex 'noGIL' did not match any buildbot builder. Is the requested builder in the list of stable builders?

@colesbury
Copy link
Contributor Author

@itamaro - I don't think there's a way to run the PRs agains the noGIL build bots, maybe because they're not marked as stable? (Although considering I just broke them, maybe it's best they weren't marked stable)

@itamaro
Copy link
Contributor

itamaro commented Sep 29, 2023

@itamaro - I don't think there's a way to run the PRs agains the noGIL build bots, maybe because they're not marked as stable? (Although considering I just broke them, maybe it's best they weren't marked stable)

I don't know if the buildbot matching is case sensitive or not, and whether it matches against builder name (would be "NoGIL") of tags (would be "nogil").
@ambv do you know what we're matching against exactly? and whether it's possible to explicitly request to not ignore unstable buildbots?

@colesbury
Copy link
Contributor Author

It's no longer case sensitive (since yesterday when vstinner changed it)

@carljm carljm merged commit 2973970 into python:main Sep 29, 2023
18 checks passed
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD 3.x has failed when building commit 2973970.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1223/builds/284) and take a look at the build logs.
  4. Check if the failure is related to this commit (2973970) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1223/builds/284

Failed tests:

  • test.test_concurrent_futures.test_shutdown

Failed subtests:

  • test_interpreter_shutdown - test.test_concurrent_futures.test_shutdown.ProcessPoolForkProcessPoolShutdownTest.test_interpreter_shutdown

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_concurrent_futures/test_shutdown.py", line 50, in test_interpreter_shutdown
    self.assertEqual(out.strip(), b"apple")
AssertionError: b'' != b'apple'

@colesbury colesbury deleted the test_cpp_ext branch March 18, 2024 15:57
colesbury added a commit to colesbury/cpython that referenced this pull request Mar 18, 2024
…l builds. (python#110123)"

The `test_cppext` can run now that the `wheel` package is updated.

This reverts commit 2973970.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
python#110123)

The current version of pip does not support "t" in the ABI flags. Skip
the test in `--disable-gil` builds until we can update pip.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants