Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.11] gh-108303: Fix and move badsyntax_pep3120.py (GH-109513) #109724

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Sep 22, 2023

(cherry picked from commit 4dd47c6)

…-109513)

Co-authored-by: Alex Waygood <[email protected]>.
(cherry picked from commit 4dd47c6)

Co-authored-by: Nikita Sobolev <[email protected]>
@vstinner
Copy link
Member

Tests fail:

ERROR: test_find_module_encoding (test.test_imp.ImportTests.test_find_module_encoding)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test_imp.py", line 83, in test_find_module_encoding
    imp.find_module('badsyntax_pep3120', path)
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/imp.py", line 297, in find_module
    raise ImportError(_ERR_MSG.format(name), name=name)
ImportError: No module named 'badsyntax_pep3120'

@sobolevn
Copy link
Member Author

test_imp is missing in 3.12 and 3.13, fixed 👍

@ambv
Copy link
Contributor

ambv commented Sep 22, 2023

There's still three failures that survive re-runs:

ERROR: test_inline_table_recursion_limit (test.test_tomllib.test_misc.TestMiscellaneous.test_inline_table_recursion_limit) (limit=137, available=99, nest_count=32)
FAIL: test_get_recursion_depth (test.test_support.TestSupport.test_get_recursion_depth)
 ERROR: test_recursion (test.test_support.TestSupport.test_recursion)

All are about exceeded recursion limits.

@AlexWaygood
Copy link
Member

ERROR: test_inline_table_recursion_limit (test.test_tomllib.test_misc.TestMiscellaneous.test_inline_table_recursion_limit) (limit=137, available=99, nest_count=32)

That one's been failing on the 3.11 branch for a while now, I think, FWIW. Don't know about the others.

@vstinner
Copy link
Member

ERROR: test_inline_table_recursion_limit (test.test_tomllib.test_misc.TestMiscellaneous.test_inline_table_recursion_limit) (limit=137, available=99, nest_count=32)
FAIL: test_get_recursion_depth (test.test_support.TestSupport.test_get_recursion_depth)
ERROR: test_recursion (test.test_support.TestSupport.test_recursion)

Sadly, these ones are regressions when I fixed a RecursionError :-( See issue GH-108851.

@vstinner vstinner merged commit 6bb18bb into python:3.11 Sep 22, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants