Docs: align the param spec of sqlite3.Connection methods with the implementation #108285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lementation - no parameters of create_aggregate() are positional-only - all parameters of create_collation() are positional-only
erlend-aasland
added
skip issue
skip news
needs backport to 3.11
|
For the record, here are the clinic inputs for these methods: cpython/Modules/_sqlite/connection.c Lines 1336 to 1346 in d7202e4 cpython/Modules/_sqlite/connection.c Lines 2100 to 2109 in d7202e4 |
|
I consider this a non-controversial change; I'll land it as soon as the CI is green. |
|
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
GH-108287 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 22, 2023
…lementation (pythonGH-108285) - no parameters of create_aggregate() are positional-only - all parameters of create_collation() are positional-only (cherry picked from commit 893215a) Co-authored-by: Erlend E. Aasland <[email protected]>
|
GH-108288 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 22, 2023
…lementation (pythonGH-108285) - no parameters of create_aggregate() are positional-only - all parameters of create_collation() are positional-only (cherry picked from commit 893215a) Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland
added a commit
that referenced
this pull request
Aug 22, 2023
…the implementation (GH-108285) (#108288) - no parameters of create_aggregate() are positional-only - all parameters of create_collation() are positional-only (cherry picked from commit 893215a) Co-authored-by: Erlend E. Aasland <[email protected]>
Yhg1s
pushed a commit
that referenced
this pull request
Aug 22, 2023
…the implementation (GH-108285) (#108287) Docs: align the param spec of sqlite3.Connection methods with the implementation (GH-108285) - no parameters of create_aggregate() are positional-only - all parameters of create_collation() are positional-only (cherry picked from commit 893215a) Co-authored-by: Erlend E. Aasland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--108285.org.readthedocs.build/