gh-107298: Add standard exceptions and warnings in the nitpick_ignore list #108029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
added
skip news
needs backport to 3.11
AA-Turner
reviewed
Aug 16, 2023
AA-Turner
approved these changes
Aug 16, 2023
vstinner
reviewed
Aug 16, 2023
| ] | ||
|
|
||
| # Temporary undocumented names. | ||
| # In future this list must be empty. |
There was a problem hiding this comment.
A fix would be to replace :c:data:`Exception` with .. c:data:`Exception` in Doc/c-api/exceptions.rst, right?
There was a problem hiding this comment.
I tried this, and it turned out not so simple. You need to specify the type:
.. c:var:: PyObject *PyExc_SomeError
and the result does not look good.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
GH-108070 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 17, 2023
…ignore list (pythonGH-108029) (cherry picked from commit c9d83f9) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-108071 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 17, 2023
…ignore list (pythonGH-108029) (cherry picked from commit c9d83f9) Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
added a commit
that referenced
this pull request
Aug 17, 2023
…_ignore list (GH-108029) (GH-108071) (cherry picked from commit c9d83f9) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--108029.org.readthedocs.build/