Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-107458: fix test_tools refleak #107577

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Aug 3, 2023

@kumaraditya303
Copy link
Contributor Author

I have verified this locally, I'll merge as the buildbots are all already broken, will check later when things are better.

@kumaraditya303 kumaraditya303 enabled auto-merge (squash) August 3, 2023 05:55
@kumaraditya303 kumaraditya303 merged commit 46366ca into python:main Aug 3, 2023
@kumaraditya303 kumaraditya303 deleted the refleak branch August 3, 2023 14:14
@Eclips4
Copy link
Member

Eclips4 commented Aug 3, 2023

Are this really solve the issue?
this code still leaks:

import sys
import importlib


name = "_decimal"
importlib.import_module(name)
sys.modules.pop(name)

./python.exe -X showrefcount example.py
[7624 refs, 4253 blocks]

@kumaraditya303
Copy link
Contributor Author

Nope, this fixes this test which was false leaking, you should try running the test_tools on current main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants