Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-107442: Document all valid types for ctypes _as_parameter_ #107443

Merged
merged 5 commits into from
Aug 7, 2023
Merged

gh-107442: Document all valid types for ctypes _as_parameter_ #107443

merged 5 commits into from
Aug 7, 2023

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Jul 29, 2023 •
edited by github-actions bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Jul 29, 2023
Closed
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Jul 29, 2023
@erlend-aasland
Copy link
Contributor

erlend-aasland commented Aug 5, 2023 •
edited
Loading

BTW, I created #107672 for the other annotation warnings in ctypes.rst.

UPDATE: I merged my annotation fix, merged in main here and resolved the conflicts I introduced with that PR.

@tomasr8 @erlend-aasland
Use correct markup for attributes
edf4e2c 
Co-authored-by: Erlend E. Aasland <[email protected]>
@erlend-aasland
Copy link
Contributor

Come to think of it, we don't usually add NEWS entries for doc updates; could you please remove the NEWS entry? (Sorry for not mentioning this earlier!)

@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Aug 7, 2023
@erlend-aasland erlend-aasland merged commit 6925c57 into python:main Aug 7, 2023
19 checks passed
@miss-islington
Copy link
Contributor

Thanks @tomasr8 for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @tomasr8 and @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6925c578a0e3cbb00858e64da813a7ffe79623c4 3.11

@bedevere-bot
Copy link

GH-107707 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Aug 7, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 7, 2023
@tomasr8 @miss-islington
pythongh-107442: Document all valid types for ctypes _as_parameter_ (p…
405630b 
…ythonGH-107443)

(cherry picked from commit 6925c57)

Co-authored-by: Tomas R <[email protected]>
@tomasr8 tomasr8 deleted the ctypes-docs branch August 7, 2023 10:46
@erlend-aasland
Copy link
Contributor

@tomasr8, do you know how to use the cherry-picker for the 3.11 backport?

@tomasr8 tomasr8 restored the ctypes-docs branch August 7, 2023 10:52
@tomasr8
Copy link
Member Author

tomasr8 commented Aug 7, 2023

@tomasr8, do you know how to use the cherry-picker for the 3.11 backport?

I have never used the tool before, but I'll give it a try :)

@erlend-aasland
Copy link
Contributor

There's some text about it in the devguide ;)

Yhg1s pushed a commit that referenced this pull request Aug 7, 2023
@miss-islington @tomasr8
[3.12] gh-107442: Document all valid types for ctypes _as_parameter_ (G…
e5582bd 
…H-107443) (#107707)

gh-107442: Document all valid types for ctypes _as_parameter_ (GH-107443)
(cherry picked from commit 6925c57)

Co-authored-by: Tomas R <[email protected]>
@bedevere-bot
Copy link

GH-107718 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 7, 2023
erlend-aasland pushed a commit that referenced this pull request Aug 7, 2023
@tomasr8
[3.11] gh-107442: Document all valid types for ctypes _as_parameter_ (
880670a 
GH-107443) (#107718)

(cherry picked from commit 6925c57)

Co-authored-by: Tomas R <[email protected]>
@tomasr8 tomasr8 deleted the ctypes-docs branch August 7, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@kamilturek kamilturek kamilturek approved these changes

Assignees

@erlend-aasland erlend-aasland

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tomasr8 @erlend-aasland @miss-islington @bedevere-bot @kamilturek