Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-107178: Add the C API tests for the Abstract Objects Layer #107179

Merged
merged 5 commits into from
Aug 7, 2023

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jul 24, 2023

Cover all the Mapping Protocol, almost all the Sequence Protocol (except PySequence_Fast) and a part of the Object Protocol.

Move existing tests to Lib/test/test_capi/test_abstract.py and Modules/_testcapi/abstract.c.

Cover all the Mapping Protocol, almost all the Sequence Protocol
(except PySequence_Fast) and a part of the Object Protocol.

Move existing tests to Lib/test/test_capi/test_abstract.py and
Modules/_testcapi/abstract.c.
@serhiy-storchaka serhiy-storchaka requested review from vstinner, encukou and erlend-aasland and removed request for a team July 25, 2023 07:32
@erlend-aasland
Copy link
Contributor

Great work! I won't be able to review this until next week.

@serhiy-storchaka serhiy-storchaka removed needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Aug 7, 2023
@serhiy-storchaka serhiy-storchaka merged commit 16c9415 into python:main Aug 7, 2023
19 checks passed
@serhiy-storchaka serhiy-storchaka deleted the test-capi-abstract branch August 7, 2023 15:51
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Aug 7, 2023
…Layer (pythonGH-107179)

Cover all the Mapping Protocol, almost all the Sequence Protocol
(except PySequence_Fast) and a part of the Object Protocol.

Move existing tests to Lib/test/test_capi/test_abstract.py and
Modules/_testcapi/abstract.c.

Add also tests for PyDict C API..
(cherry picked from commit 16c9415)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot
Copy link

GH-107728 is a backport of this pull request to the 3.12 branch.

Yhg1s pushed a commit that referenced this pull request Aug 16, 2023
…H-107179) (#107728)

Cover all the Mapping Protocol, almost all the Sequence Protocol
(except PySequence_Fast) and a part of the Object Protocol.

Move existing tests to Lib/test/test_capi/test_abstract.py and
Modules/_testcapi/abstract.c.

Add also tests for PyDict C API..
(cherry picked from commit 16c9415)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir topic-C-API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants