gh-104050: Argument Clinic: Annotate CLanguage.render_option_group_parsing() #106929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
erlend-aasland
commented
Jul 20, 2023
•
erlend-aasland
commented
- Issue: Add type annotations to clinic.py #104050
AlexWaygood
reviewed
Jul 20, 2023
AlexWaygood
reviewed
Jul 20, 2023
erlend-aasland
commented
Jul 20, 2023
erlend-aasland
commented
Jul 20, 2023
Extra quotes around Parameter are not needed anymore Co-authored-by: Alex Waygood <[email protected]>
Rip out ParamIter
AlexWaygood
reviewed
Jul 20, 2023
| @@ -1415,6 +1419,7 @@ def render_option_group_parsing(self, f, template_dict): | |||
| group = required | |||
| else: | |||
| right.append(group) | |||
| assert group is not None | |||
There was a problem hiding this comment.
This is fine for now, but I feel like there's probably a simpler way of writing the code immediately above that would be easier to understand and not require this assertion here for mypy
There was a problem hiding this comment.
Yes. We should accumulate these smells in the modernising-issue, so we don't forget. Or we can just grep for asserts.
Co-authored-by: Alex Waygood <[email protected]>
Thanks, the same! |
erlend-aasland
deleted the
clinic/annotate-clanguage-render-option-group-parsing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.