Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-106078: Prepare to isolate decimal module #106880

Merged
merged 3 commits into from
Jul 20, 2023

Conversation

CharlieZhao95
Copy link
Contributor

@CharlieZhao95 CharlieZhao95 commented Jul 19, 2023

The DecCondMap contains a potentially global variable(ex, a subclass of DecimalException). We should also move signal_map and cond_map to module state.

  • Move signal_map and cond_map to global state
  • Initialize array of DecCondMap using heap memory (Prepare to isolate module)

@CharlieZhao95
Copy link
Contributor Author

cc: @erlend-aasland @kumaraditya303

@CharlieZhao95 CharlieZhao95 marked this pull request as ready for review July 19, 2023 07:04
@rhettinger rhettinger removed their request for review July 19, 2023 19:54
@kumaraditya303
Copy link
Contributor

root@codespaces-62bef3 /w/cpython (decimal/move_condmap)# ./python -m test -R 3:3 test_decimal
0:00:00 load avg: 37.18 Run tests sequentially
0:00:00 load avg: 37.18 [1/1] test_decimal
beginning 6 repetitions
123456
......

== Tests result: SUCCESS ==

1 test OK.

Total duration: 26.0 sec
Tests result: SUCCESS

@kumaraditya303 kumaraditya303 enabled auto-merge (squash) July 20, 2023 09:23
@kumaraditya303 kumaraditya303 enabled auto-merge (squash) July 20, 2023 09:23
@kumaraditya303 kumaraditya303 merged commit a1620dd into python:main Jul 20, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants