Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-106669: Revert "gh-102988: Detect email address parsing errors ... (#105127)" #106733

Merged
merged 4 commits into from
Jul 21, 2023
Merged

gh-106669: Revert "gh-102988: Detect email address parsing errors ... (#105127)" #106733

merged 4 commits into from
Jul 21, 2023

Conversation

gpshead
Copy link
Member

@gpshead gpshead commented Jul 14, 2023 •
edited
Loading

gh-106669: Revert "gh-102988: Detect email address parsing errors and return empty tuple to indicate the parsing error (old API) (#105127)"

This reverts commit 18dfbd0 and adds the regression test suggested in the issue.

See #106669.

📚 Documentation preview 📚: https://cpython-previews--106733.org.readthedocs.build/

gpshead added 2 commits July 13, 2023 17:42
@gpshead
pythongh-106669: Revert "pythongh-102988: Detect email address parsin…
362793e 
…g errors and return empty tuple to indicate the parsing error (old API) (python#105127)"

This reverts commit 18dfbd0.

See python#106669.
@gpshead
Keep a news entry. Describe the revert and bug.
c8f5af2
@gpshead gpshead added type-bug An unexpected behavior, bug, or error needs backport to 3.12 bug and security fixes labels Jul 14, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 14, 2023
Closed
@gpshead gpshead marked this pull request as ready for review July 14, 2023 00:55
@gpshead gpshead requested a review from a team as a code owner July 14, 2023 00:55
@gpshead gpshead self-assigned this Jul 14, 2023
@gpshead gpshead requested a review from Yhg1s July 14, 2023 00:56
@felixxm felixxm mentioned this pull request Jul 17, 2023
Merged
@gpshead gpshead merged commit a31dea1 into python:main Jul 21, 2023
@miss-islington
Copy link
Contributor

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @gpshead, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a31dea1feb61793e48fa9aa5014f358352205c1d 3.12

@gpshead gpshead deleted the gh-106669 branch July 21, 2023 03:30
@gpshead gpshead added needs backport to 3.12 bug and security fixes and removed needs backport to 3.12 bug and security fixes labels Jul 21, 2023
@miss-islington
Copy link
Contributor

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @gpshead, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker a31dea1feb61793e48fa9aa5014f358352205c1d 3.12

@gpshead gpshead added needs backport to 3.12 bug and security fixes and removed needs backport to 3.12 bug and security fixes labels Jul 21, 2023
@miss-islington
Copy link
Contributor

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @gpshead, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker a31dea1feb61793e48fa9aa5014f358352205c1d 3.12

gpshead added a commit to gpshead/cpython that referenced this pull request Jul 21, 2023
@gpshead
[3.12] pythongh-106669: Revert "pythongh-102988: Detect email address…
4288c62 
… parsing errors ... (pythonGH-105127)" (pythonGH-106733)

This reverts commit 18dfbd0.
Adds a regression test from the issue.

See python#106669..
(cherry picked from commit a31dea1)

Co-authored-by: Gregory P. Smith <[email protected]>
@bedevere-bot
Copy link

GH-106941 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jul 21, 2023
gpshead added a commit that referenced this pull request Jul 21, 2023
@gpshead
[3.12] gh-106669: Revert "gh-102988: Detect email address parsing err…
656f624 
…ors ... (GH-105127)" (GH-106733) (#106941)

This reverts commit 18dfbd0.
Adds a regression test from the issue.

See #106669..
(cherry picked from commit a31dea1)
@gpshead gpshead mentioned this pull request Dec 14, 2023
Merged
@smoser smoser mentioned this pull request Feb 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yhg1s Yhg1s Awaiting requested review from Yhg1s

Assignees

@gpshead gpshead

Labels
release-blocker type-bug An unexpected behavior, bug, or error
Projects
Release and Deferred blockers 🚫
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gpshead @miss-islington @bedevere-bot