Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-106503: asyncio._SelectorSocketTransport: free another cyclic reference on close(). #106504

Merged
merged 1 commit into from
Jul 7, 2023
Merged

gh-106503: asyncio._SelectorSocketTransport: free another cyclic reference on close(). #106504

merged 1 commit into from
Jul 7, 2023

Conversation

pteromys
Copy link
Contributor

@pteromys pteromys commented Jul 7, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Jul 7, 2023
Closed
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Jul 7, 2023 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@kumaraditya303 kumaraditya303 merged commit 3e5ce79 into python:main Jul 7, 2023
@miss-islington
Copy link
Contributor

Thanks @pteromys for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-106514 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jul 7, 2023
kumaraditya303 pushed a commit that referenced this pull request Jul 7, 2023
@miss-islington @pteromys
[3.12] gh-106503: asyncio._SelectorSocketTransport: fix cyclic refere…
7e883d7 
…nce on close(). (GH-106504) (#106514)

gh-106503: asyncio._SelectorSocketTransport: fix cyclic reference on close(). (GH-106504)
(cherry picked from commit 3e5ce79)

Co-authored-by: Andrew Geng <[email protected]>
@pteromys pteromys deleted the fix-issue-106503 branch July 7, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
topic-asyncio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pteromys @miss-islington @bedevere-bot @kumaraditya303