-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-106310 - document the __signature__ attribute #106311
Conversation
There's an existing version added note for 3.3 for the entire Signature subsection in the inspect docs, so there is no need to add one for this specifically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Thanks @Gouvernathor for the PR, and @ncoghlan for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Document the __signature__ attribute (cherry picked from commit b07f232) Co-authored-by: Gouvernathor <[email protected]> Co-authored-by: Alex Waygood <[email protected]>
Document the __signature__ attribute (cherry picked from commit b07f232) Co-authored-by: Gouvernathor <[email protected]> Co-authored-by: Alex Waygood <[email protected]>
GH-111145 is a backport of this pull request to the 3.12 branch. |
GH-111146 is a backport of this pull request to the 3.11 branch. |
Thanks ! 🎉 |
…111145) Co-authored-by: Gouvernathor <[email protected]> Co-authored-by: Alex Waygood <[email protected]>
…111146) Co-authored-by: Gouvernathor <[email protected]> Co-authored-by: Alex Waygood <[email protected]>
Document the __signature__ attribute Co-authored-by: Alex Waygood <[email protected]>
See #115937 |
Document the __signature__ attribute Co-authored-by: Alex Waygood <[email protected]>
The inspect.unwrap entry already makes clear that wrappers over a signatured function are recognized.
Maybe it would be worth adding a
.. versionadded::
entry, I'm not sure, but in that case I don't know what version I should target.📚 Documentation preview 📚: https://cpython-previews--106311.org.readthedocs.build/