Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-106310 - document the __signature__ attribute #106311

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

Gouvernathor
Copy link
Contributor

@Gouvernathor Gouvernathor commented Jul 1, 2023

The inspect.unwrap entry already makes clear that wrappers over a signatured function are recognized.

Maybe it would be worth adding a .. versionadded:: entry, I'm not sure, but in that case I don't know what version I should target.


📚 Documentation preview 📚: https://cpython-previews--106311.org.readthedocs.build/

@ncoghlan
Copy link
Contributor

There's an existing version added note for 3.3 for the entire Signature subsection in the inspect docs, so there is no need to add one for this specifically.

Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ncoghlan ncoghlan added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Oct 20, 2023
@ncoghlan ncoghlan merged commit b07f232 into python:main Oct 20, 2023
21 checks passed
@miss-islington-app
Copy link

Thanks @Gouvernathor for the PR, and @ncoghlan for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 20, 2023
Document the __signature__ attribute

(cherry picked from commit b07f232)

Co-authored-by: Gouvernathor <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 20, 2023
Document the __signature__ attribute

(cherry picked from commit b07f232)

Co-authored-by: Gouvernathor <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 20, 2023

GH-111145 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Oct 20, 2023
@bedevere-app
Copy link

bedevere-app bot commented Oct 20, 2023

GH-111146 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 20, 2023
@Gouvernathor Gouvernathor deleted the patch-6 branch October 20, 2023 23:05
@Gouvernathor
Copy link
Contributor Author

Thanks ! 🎉

hugovk pushed a commit that referenced this pull request Oct 23, 2023
hugovk pushed a commit that referenced this pull request Oct 23, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Document the __signature__ attribute

Co-authored-by: Alex Waygood <[email protected]>
@skirpichev
Copy link
Member

See #115937

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Document the __signature__ attribute

Co-authored-by: Alex Waygood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants