-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-102251: Fix reference leak in _testsinglephase initialization #105082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sunmy2019
commented
May 30, 2023
•
edited by bedevere-bot
Loading
edited by bedevere-bot
- Issue: Fix Refleak in test_import #102251
erlend-aasland
approved these changes
May 30, 2023
erlend-aasland
changed the title
gh-102251: add missing decref in testsinglephase
gh-102251: Fix reference leak in _testsinglephase initialization
May 30, 2023
Thanks |
Thanks @sunmy2019 for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
GH-105083 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 30, 2023
pythonGH-105082) Correctly decref 'initialized' in init_module() (cherry picked from commit d14eb34) Co-authored-by: sunmy2019 <[email protected]> Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland
added a commit
that referenced
this pull request
May 30, 2023
…on (GH-105082) (#105083) Correctly decref 'initialized' in init_module() (cherry picked from commit d14eb34) Co-authored-by: sunmy2019 <[email protected]> Co-authored-by: Erlend E. Aasland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.