Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.7] gh-102950: Implement PEP 706 – Filter for tarfile.extractall (GH-102953) #104583

Closed
wants to merge 13 commits into from

Conversation

encukou
Copy link
Member

@encukou encukou commented May 17, 2023

See Backporting & Forward Compatibility in PEP 706.

  • Backport b52ad18
  • Backport c8c3956
  • Remove the DeprecationWarning
  • Remove new __all__ entries
  • Adjust docs
  • Backport a warning to shutil.unpack_archive docs

Nearly the same as the 3.8 backport, but it also backports the test.support.check_no_warnings function from 3.8+, since it's used in new tests.

@encukou
Copy link
Member Author

encukou commented May 18, 2023

Python 3.7, Windows and symlinks, oh my!
I'll investigate & fix next week.

@encukou
Copy link
Member Author

encukou commented May 29, 2023

@ned-deily this was quite a rabbit hole, and I'm as far as I can go. Unfortunately, not far enough. See Discourse for details: https://discuss.python.org/t/23903/11

I'll run buildbots to check if this is fine for non-Windows platforms, but I don't think CPython 3.7 can ship it :(

@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 29, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit 773e47e 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 29, 2023
@ned-deily
Copy link
Member

[...] but I don't think CPython 3.7 can ship it :(

Thank you, Petr, for all your work on this across all the active branches! Given your analysis of the current 3.7 patch's shortcoming and give that 3.7 is scheduled to reach end-of-life in just a few weeks, I agree with your conclusion that it would be too risky and disruptive to officially accept this change for 3.7. As you note, third-party distributors who plan to provide support for 3.7 beyond its official end-of-life date are free to use and adapt the patch for their customers and they will have the opportunity to provide updates to it as necessary. Considering that the shortcomings that this change address have existed and been documented for many years and considering that all subsequent versions of Python (i.e. 3.8 on) will have this fix available, I do not think there is a need to consider either rushing a fix into 3.7 before its end-of-life or extending 3.7's life.

@ned-deily ned-deily closed this May 30, 2023
@encukou
Copy link
Member Author

encukou commented May 30, 2023

All buildbot failures look unrelated -- cryptography/network, USAN/ASAN, unsupported platforms/missing tools (MSVC toolset version, Tk, Wasm, Windows ARM), timeouts, a readline fail.

They shouldn't prevent building Python 3.7 from source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants