New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] GH-89812: Add `tarfile.TarPath` #104272

Closed

barneygale wants to merge 2 commits into python:main from barneygale:gh-89812-tarpath

Contributor

barneygale commented May 7, 2023 •

edited

Loading

Split pathlib.Path into _AbstractPath and Path
- Make _AbstractPath.stat(), open() and iterdir() abstract
- Implement _AbstractPath._scandir() via iterdir()
  - Add follow_symlinks argument to is_dir() for consistency with os.DirEntry.is_dir()
  - Use context manager enter value in walk() to enable use of a contextlib.nullcontext()
- Implement _AbstractPath.is_mount() and is_junction() using stat(), restoring implementation from before gh-86943: implement pathlib.WindowsPath.is_mount() #31458 in the former case.
[more to come!]

Issue: Add tarfile.TarPath #89812


          Add pathlib._AbstractPath

042cb6c

barneygale added the topic-pathlib label

bedevere-bot mentioned this pull request

Add tarfile.TarPath #89812

Open

bedevere-bot added the awaiting core review label


          Add tests for pathlib._AbstractPath

59cf62b

Contributor Author

barneygale commented Jun 28, 2023

Closing - will log a fresh PR soon :)

barneygale closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review topic-pathlib