Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-97696 Remove unnecessary check for eager_start kwarg #104188

Merged
merged 7 commits into from
May 9, 2023
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions Lib/asyncio/tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -931,18 +931,21 @@ def callback():


def create_eager_task_factory(custom_task_constructor):

if "eager_start" not in inspect.signature(custom_task_constructor).parameters:
raise TypeError(
"Provided constructor does not support eager task execution")
"""
Creates a function suitable for use as a task factory on an event-loop.
The tasks created will be started immediately (rather than being first
jbower-fb marked this conversation as resolved.
Show resolved Hide resolved
scheduled to an event loop). The constructor argument can be any callable
that constructs a Task-compatible object and supports the eager_start
keyword argument.
jbower-fb marked this conversation as resolved.
Show resolved Hide resolved
"""

def factory(loop, coro, *, name=None, context=None):
return custom_task_constructor(
coro, loop=loop, name=name, context=context, eager_start=True)


return factory


eager_task_factory = create_eager_task_factory(Task)


Expand Down