-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-103793: Defer formatting task name #103767
Commits on Apr 24, 2023
-
The default task name is "Task-<counter>" (if no name is passed in during Task creation). This is initialized in `Task.__init__` (C impl) using string formatting, which can be quite slow. Actually using the task name in real world code is not very common, so this is wasted init. Let's defer this string formatting to the first time the name is read (in `get_name` impl), so we don't need to pay the string formatting cost if the task name is never read.
Configuration menu - View commit details
-
Copy full SHA for e8353cc - Browse repository at this point
Copy the full SHA e8353ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1822ff8 - Browse repository at this point
Copy the full SHA 1822ff8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74d0084 - Browse repository at this point
Copy the full SHA 74d0084View commit details
Commits on Apr 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for dbc7047 - Browse repository at this point
Copy the full SHA dbc7047View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bb6c1e - Browse repository at this point
Copy the full SHA 2bb6c1eView commit details -
replace storing the task counter on task construction with just getti…
…ng the next counter at lazy name generation
Configuration menu - View commit details
-
Copy full SHA for 2efd376 - Browse repository at this point
Copy the full SHA 2efd376View commit details -
Merge branch 'defer-task-name-formatting' of github.com:itamaro/cpyth…
…on into defer-task-name-formatting
Configuration menu - View commit details
-
Copy full SHA for 6cb321b - Browse repository at this point
Copy the full SHA 6cb321bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7cde290 - Browse repository at this point
Copy the full SHA 7cde290View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b50646 - Browse repository at this point
Copy the full SHA 4b50646View commit details -
Configuration menu - View commit details
-
Copy full SHA for a155190 - Browse repository at this point
Copy the full SHA a155190View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb2bd7f - Browse repository at this point
Copy the full SHA fb2bd7fView commit details
Commits on Apr 26, 2023
-
Switch back to original "assign task number at construction" but stor…
…e the counter as PyLong for deferred formatting
Configuration menu - View commit details
-
Copy full SHA for 41e9a59 - Browse repository at this point
Copy the full SHA 41e9a59View commit details -
Add test that using an explicit PyLong as task name does not accident…
…ally trigger the deferred name formatting logic
Configuration menu - View commit details
-
Copy full SHA for 712edf9 - Browse repository at this point
Copy the full SHA 712edf9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 592d44b - Browse repository at this point
Copy the full SHA 592d44bView commit details