Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-102799: use sys.exception() instead of sys.exc_info() in contextlib #103311

Merged
merged 7 commits into from
Jul 20, 2023
Merged

gh-102799: use sys.exception() instead of sys.exc_info() in contextlib #103311

merged 7 commits into from
Jul 20, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Apr 6, 2023 •
edited by bedevere-bot
Loading

This will be further simplified when PEP-707 or something like that is implemented, but for now I think this clarifies where we still need the triplet.

@iritkatriel iritkatriel requested a review from 1st1 as a code owner April 6, 2023 11:58
@bedevere-bot bedevere-bot mentioned this pull request Apr 6, 2023
Closed
@iritkatriel iritkatriel requested a review from ambv April 24, 2023 20:36
kumaraditya303
kumaraditya303 reviewed Jul 16, 2023
View reviewed changes
Lib/contextlib.py Outdated Show resolved Hide resolved
@iritkatriel @kumaraditya303
exc_details[1] --> exc
cc74903 
Co-authored-by: Kumar Aditya <[email protected]>
@kumaraditya303 kumaraditya303 merged commit eeff8e7 into python:main Jul 20, 2023
17 checks passed
@iritkatriel iritkatriel deleted the exc_info-contextlib branch July 25, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@ambv ambv Awaiting requested review from ambv

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iritkatriel @kumaraditya303 @bedevere-bot