bpo-26558: Fix Py_FatalError() with GIL released #10267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't call _Py_FatalError_PrintExc() nor flush_std_files() if the thread doesn't hold the GIL, or if the thread has no Python state thread.
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 31, 2018
Don't call _Py_FatalError_PrintExc() nor flush_std_files() if the current thread doesn't hold the GIL, or if the current thread has no Python state thread. (cherry picked from commit 3a228ab) Co-authored-by: Victor Stinner <[email protected]>
|
GH-10269 is a backport of this pull request to the 3.7 branch. |
|
Sorry, @vstinner, I could not cleanly backport this to |
|
GH-10270 is a backport of this pull request to the 3.6 branch. |
miss-islington
added a commit
that referenced
this pull request
Oct 31, 2018
Don't call _Py_FatalError_PrintExc() nor flush_std_files() if the current thread doesn't hold the GIL, or if the current thread has no Python state thread. (cherry picked from commit 3a228ab) Co-authored-by: Victor Stinner <[email protected]>
vstinner
added a commit
that referenced
this pull request
Nov 1, 2018
rwgk
pushed a commit
to rwgk/pybind11
that referenced
this pull request
Mar 26, 2021
Possibly, this explains why PyGILState_Check() cannot safely be used with Python 3.4 and 3.5: python/cpython#10267 (comment)
rwgk
pushed a commit
to rwgk/pybind11
that referenced
this pull request
Apr 2, 2021
Possibly, this explains why PyGILState_Check() cannot safely be used with Python 3.4 and 3.5: python/cpython#10267 (comment)
rwgk
pushed a commit
to pybind/pybind11
that referenced
this pull request
Apr 3, 2021
* Adding PyGILState_Check() in object_api<>::operator(). * Enabling PyGILState_Check() for Python >= 3.6 only. Possibly, this explains why PyGILState_Check() cannot safely be used with Python 3.4 and 3.5: python/cpython#10267 (comment) * Adding simple micro benchmark. * Reducing test time to minimum (purely for coverage, not for accurate results). * Fixing silly oversight. * Minor code organization improvement in test. * Adding example runtimes. * Removing capsys (just run with `-k test_callback_num_times -s` and using `.format()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace PyThreadState_GET() with PyGILState_GetThisThreadState() in
_Py_FatalError_PrintExc().
PyThreadState_GET() must not be called with the GIL released: it
reports the wrong Python thread state.
PyGILState_GetThisThreadState() returns NULL if called from a C
thread which has no Python thread state attached.
https://bugs.python.org/issue26558