gh-101979: fix a bug that parentheses in metavar argument of add_argument() were dropped #102318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JelleZijlstra |
corona10
reviewed
Mar 1, 2023
corona10
reviewed
Mar 1, 2023
Misc/NEWS.d/next/Library/2023-02-28-09-52-25.gh-issue-101979.or3hXV.rst
Outdated
Show resolved
Hide resolved
| @@ -3764,6 +3764,28 @@ class TestHelpUsage(HelpTestCase): | |||
| version = '' | |||
|
|
|||
|
|
|||
| class TestHelpUsageWithParentheses(HelpTestCase): | |||
There was a problem hiding this comment.
I don't see any tests that actually add parentheses for a group with more than one action. Could you add one?
There was a problem hiding this comment.
That's a good idea. But I think the testcase you want already exists using the code below. Please review it.
cpython/Lib/test/test_argparse.py
Line 2777 in 66aa78c
There was a problem hiding this comment.
You're right, thanks! There are a lot of tests, I must have glanced over that one.
…r3hXV.rst Co-authored-by: Jelle Zijlstra <[email protected]>
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! : please review the changes made to this pull request. |
JelleZijlstra
approved these changes
Mar 5, 2023
JelleZijlstra
added
needs backport to 3.10
|
Thanks @yeojin-dev for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-102438 is a backport of this pull request to the 3.11 branch. |
|
GH-102439 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 5, 2023
…ument of add_argument() were dropped (pythonGH-102318) (cherry picked from commit 9a478be) Co-authored-by: Yeojin Kim <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 5, 2023
…ument of add_argument() were dropped (pythonGH-102318) (cherry picked from commit 9a478be) Co-authored-by: Yeojin Kim <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Mar 5, 2023
…of add_argument() were dropped (GH-102318) (cherry picked from commit 9a478be) Co-authored-by: Yeojin Kim <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Mar 5, 2023
…of add_argument() were dropped (GH-102318) (cherry picked from commit 9a478be) Co-authored-by: Yeojin Kim <[email protected]>
hugovk
pushed a commit
to hugovk/cpython
that referenced
this pull request
Mar 6, 2023
…ument of add_argument() were dropped (python#102318)
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Mar 6, 2023
* main: (21 commits) pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives in sub interpreters module (python#102472) pythongh-95672: Fix versionadded indentation of get_pagesize in test.rst (pythongh-102455) pythongh-102416: Do not memoize incorrectly loop rules in the parser (python#102467) pythonGH-101362: Optimise PurePath(PurePath(...)) (pythonGH-101667) pythonGH-101362: Check pathlib.Path flavour compatibility at import time (pythonGH-101664) pythonGH-101362: Call join() only when >1 argument supplied to pathlib.PurePath() (python#101665) pythongh-102444: Fix minor bugs in `test_typing` highlighted by pyflakes (python#102445) pythonGH-102341: Improve the test function for pow (python#102342) Fix unused classes in a typing test (pythonGH-102437) pythongh-101979: argparse: fix a bug where parentheses in metavar argument of add_argument() were dropped (python#102318) pythongh-102356: Add thrashcan macros to filter object dealloc (python#102426) Move around example in to_bytes() to avoid confusion (python#101595) pythonGH-97546: fix flaky asyncio `test_wait_for_race_condition` test (python#102421) pythongh-96821: Add config option `--with-strict-overflow` (python#96823) pythongh-101992: update pstlib module documentation (python#102133) pythongh-63301: Set exit code when tabnanny CLI exits on error (python#7699) pythongh-101863: Fix wrong comments in EUC-KR codec (pythongh-102417) pythongh-102302 Micro-optimize `inspect.Parameter.__hash__` (python#102303) pythongh-102179: Fix `os.dup2` error reporting for negative fds (python#102180) pythongh-101892: Fix `SystemError` when a callable iterator call exhausts the iterator (python#101896) ...
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Mar 7, 2023
* main: (37 commits) pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives in sub interpreters module (python#102472) pythongh-95672: Fix versionadded indentation of get_pagesize in test.rst (pythongh-102455) pythongh-102416: Do not memoize incorrectly loop rules in the parser (python#102467) pythonGH-101362: Optimise PurePath(PurePath(...)) (pythonGH-101667) pythonGH-101362: Check pathlib.Path flavour compatibility at import time (pythonGH-101664) pythonGH-101362: Call join() only when >1 argument supplied to pathlib.PurePath() (python#101665) pythongh-102444: Fix minor bugs in `test_typing` highlighted by pyflakes (python#102445) pythonGH-102341: Improve the test function for pow (python#102342) Fix unused classes in a typing test (pythonGH-102437) pythongh-101979: argparse: fix a bug where parentheses in metavar argument of add_argument() were dropped (python#102318) pythongh-102356: Add thrashcan macros to filter object dealloc (python#102426) Move around example in to_bytes() to avoid confusion (python#101595) pythonGH-97546: fix flaky asyncio `test_wait_for_race_condition` test (python#102421) pythongh-96821: Add config option `--with-strict-overflow` (python#96823) pythongh-101992: update pstlib module documentation (python#102133) pythongh-63301: Set exit code when tabnanny CLI exits on error (python#7699) pythongh-101863: Fix wrong comments in EUC-KR codec (pythongh-102417) pythongh-102302 Micro-optimize `inspect.Parameter.__hash__` (python#102303) pythongh-102179: Fix `os.dup2` error reporting for negative fds (python#102180) pythongh-101892: Fix `SystemError` when a callable iterator call exhausts the iterator (python#101896) ...
This was referenced May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a regular expression that removes parentheses. Instead, add parentheses only if you use two or more non required and non suppressed actions.