Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.10] gh-101981: Build macOS as recommended by the devguide (GH-102070) #102073

Merged
merged 1 commit into from
Feb 20, 2023
Merged

[3.10] gh-101981: Build macOS as recommended by the devguide (GH-102070) #102073

merged 1 commit into from
Feb 20, 2023

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 20, 2023 •
edited by bedevere-bot
Loading

(cherry picked from commit 2713631)

Co-authored-by: Erlend E. Aasland [email protected]
Automerge-Triggered-By: GH:erlend-aasland

@erlend-aasland @miss-islington
pythongh-101981: Build macOS as recommended by the devguide (pythonGH…
1054aa5 
…-102070)

(cherry picked from commit 2713631)

Co-authored-by: Erlend E. Aasland <[email protected]>
Automerge-Triggered-By: GH:erlend-aasland
This was referenced Feb 20, 2023
Closed
Merged
@erlend-aasland
Copy link
Contributor

cc. @corona10, @hugovk: any idea regarding the OpenSSL 3.1.0-beta1 failure?

@corona10
Copy link
Member 

install apps/openssl -> /home/runner/work/cpython/cpython/multissl/openssl/3.1.0-beta1/bin/openssl
install tools/c_rehash -> /home/runner/work/cpython/cpython/multissl/openssl/3.1.0-beta1/bin/c_rehash
/home/runner/work/cpython/cpython/multissl/openssl/3.1.0-beta1/bin/openssl: error while loading shared libraries: libssl.so.3: cannot open shared object file: No such file or directory

@corona10
Copy link
Member

corona10 commented Feb 20, 2023 •
edited
Loading

Re-run the job?, I would like to check if this is a temporal issue or not.

@corona10
Copy link
Member

Ah okay..


install libssl.so.3 -> /home/runner/work/cpython/cpython/multissl/openssl/3.1.0-beta1/lib64/libssl.so.3
/home/runner/work/cpython/cpython/multissl/openssl/3.1.0-beta1/bin/openssl: error while loading shared libraries: libssl.so.3: cannot open shared object file: No such file or directory

@hugovk
Copy link
Member

hugovk commented Feb 20, 2023

It's a failing Ubuntu job, so unrelated to this PR.

@corona10
Copy link
Member

corona10 commented Feb 20, 2023 •
edited
Loading

It's a failing Ubuntu job, so unrelated to this PR.

+1, Should be solved by a separate issue.

@erlend-aasland
Copy link
Contributor

cc. @pablogsal as RM for Python 3.10; see comments about failing CI. Are you fine with me landing this?

@pablogsal
Copy link
Member

pablogsal commented Feb 20, 2023 •
edited
Loading

Thanks for checking with me!

This looks good to me but I am not sure what comment are your referring to about failing CI. It seems that the issue in the CI was transient/unrelated, no?

@hugovk
Copy link
Member

hugovk commented Feb 20, 2023

Yes, unrelated, and also failing on a clean 3.10 run:

https://github.com/hugovk/cpython/actions/runs/4224278452/jobs/7335046068

@erlend-aasland erlend-aasland merged commit 63877f6 into python:3.10 Feb 20, 2023
@miss-islington miss-islington deleted the backport-2713631-3.10 branch February 20, 2023 14:52
@corona10
Copy link
Member

See how to fix it: #102079

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@corona10 corona10 corona10 approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@miss-islington @erlend-aasland @corona10 @hugovk @pablogsal @bedevere-bot