Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-101825: mention, that as_integer_ratio() output is normalized #101843

Merged
merged 11 commits into from
Feb 27, 2023
Merged

gh-101825: mention, that as_integer_ratio() output is normalized #101843

merged 11 commits into from
Feb 27, 2023

Conversation

skirpichev
Copy link
Member

@skirpichev skirpichev commented Feb 12, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Feb 12, 2023
Closed
@skirpichev
Copy link
Member Author

For some context:

@arhadthedev arhadthedev added docs Documentation in the Doc dir skip news labels Feb 12, 2023
OTheDev
OTheDev reviewed Feb 12, 2023
View reviewed changes
Doc/library/stdtypes.rst Outdated Show resolved Hide resolved
OTheDev
OTheDev reviewed Feb 12, 2023
View reviewed changes
Doc/library/stdtypes.rst Outdated Show resolved Hide resolved
OTheDev
OTheDev approved these changes Feb 12, 2023
View reviewed changes
Copy link
Contributor

@OTheDev OTheDev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me!

One last nitpick (up to you though, of course) - I really like the language you used for float.as_integer_ratio() in floatobject.c.h/floatobject.c and would also like to see that reused in stdtypes.rst for better flow and consistency (: In particular, I think it reads better when split up into multiple, smaller sentences.

Overall, I think this is a positive change! Thanks!

@skirpichev
Copy link
Member Author

@OTheDev, thanks for the review. Could you, please, take a look on last two commits?

OTheDev
OTheDev reviewed Feb 13, 2023
View reviewed changes
Doc/library/stdtypes.rst Outdated Show resolved Hide resolved
OTheDev
OTheDev reviewed Feb 13, 2023
View reviewed changes
Copy link
Contributor

@OTheDev OTheDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See specific comments.

@ericsnowcurrently ericsnowcurrently removed their request for review February 13, 2023 22:58
mdickinson
mdickinson reviewed Feb 26, 2023
View reviewed changes
Lib/fractions.py Outdated Show resolved Hide resolved
@OTheDev
Copy link
Contributor

OTheDev commented Feb 27, 2023

This looks like a nice consolidation of the language used to describe as_integer_ratio(). The descriptions are now also more exact! 👍

mdickinson
mdickinson approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson mdickinson merged commit 4624987 into python:main Feb 27, 2023
@skirpichev skirpichev deleted the as_integer_ratio-docs branch February 28, 2023 02:21
@skirpichev
Copy link
Member Author

Thanks to all.

carljm added a commit to carljm/cpython that referenced this pull request Feb 28, 2023
@carljm
Merge branch 'main' into inlinecomp2
73dc0ed 
* main: (67 commits)
  pythongh-99108: Add missing md5/sha1 defines to Modules/Setup (python#102308)
  pythongh-100227: Move _str_replace_inf to PyInterpreterState (pythongh-102333)
  pythongh-100227: Move the dtoa State to PyInterpreterState (pythongh-102331)
  pythonGH-102305: Expand some macros in generated_cases.c.h (python#102309)
  Migrate to new PSF mailgun account (python#102284)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Python/) (python#102193)
  pythonGH-90744: Fix erroneous doc links in the sys module (python#101319)
  pythongh-87092: Make jump target label equal to the offset of the target in the instructions sequence (python#102093)
  pythongh-101101: Unstable C API tier (PEP 689) (pythonGH-101102)
  IDLE: Simplify DynOptionsMenu __init__code (python#101371)
  pythongh-101561: Add typing.override decorator (python#101564)
  pythongh-101825: Clarify that as_integer_ratio() output is always normalized (python#101843)
  pythongh-101773: Optimize creation of Fractions in private methods (python#101780)
  pythongh-102251: Updates to test_imp Toward Fixing Some Refleaks (pythongh-102254)
  pythongh-102296 Document that inspect.Parameter kinds support ordering (pythonGH-102297)
  pythongh-102250: Fix double-decref in COMPARE_AND_BRANCH error case (pythonGH-102287)
  pythongh-101100: Fix sphinx warnings in `types` module (python#102274)
  pythongh-91038: Change default argument value to `False` instead of `0` (python#31621)
  pythongh-101765: unicodeobject: use Py_XDECREF correctly (python#102283)
  [doc] Improve grammar/fix missing word (pythonGH-102060)
  ...
scoder added a commit to scoder/quicktions that referenced this pull request Mar 19, 2023
@scoder
Improve docstring of Fraction.as_integer_ratio(), following python/cp…
fb7be90 
…ython#101843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OTheDev OTheDev OTheDev approved these changes

@arhadthedev arhadthedev arhadthedev left review comments

@mdickinson mdickinson mdickinson approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skirpichev @OTheDev @mdickinson @arhadthedev @bedevere-bot