Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-101561: Add typing.override decorator #101564

Merged
merged 10 commits into from
Feb 27, 2023
Merged

gh-101561: Add typing.override decorator #101564

merged 10 commits into from
Feb 27, 2023
+127 −0

Commits on Feb 27, 2023

  1. PEP 698: Add typing.override decorator 

    Testing:

First set up the repo, following instructions
at https://devguide.python.org/ by running:
```
./configure --with-pydebug && make -j
```

Then run the typing tests:
```
./python -m test test_typing -v
```

I ran the full test suite with
```
./python -m test -j3
```
and it came back clean except for a `test_grp` failure which I seem to
get on trunk as well - likely something in my build is misconfigured
but I'm pretty sure it is unrelated to the changes here.
    @stroxler
    stroxler committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    e2349bb View commit details
    Browse the repository at this point in the history

  2. Add missing For example:: in the rst doc

    @stroxler
    stroxler committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    bd3b6ac View commit details
    Browse the repository at this point in the history

  3. 📜🤖 Added by blurb_it.

    @blurb-it @stroxler
    blurb-it[bot] authored and stroxler committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    c3b9b7f View commit details
    Browse the repository at this point in the history

  4. Update Doc/library/typing.rst 

    Correct `s/final/override` (from reusing a similar block of documentation on the `@final` decorator)

Co-authored-by: Jelle Zijlstra <[email protected]>
    @stroxler @JelleZijlstra
    stroxler and JelleZijlstra committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    c7cecf8 View commit details
    Browse the repository at this point in the history

  5. Add whatsnew entry, as per Alex Waygood's suggestion 

    Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
    @stroxler
    stroxler committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    2acf32f View commit details
    Browse the repository at this point in the history

  6. Add ACKS entry, fix rst errors 

    Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
    @stroxler
    stroxler committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    6bd3356 View commit details
    Browse the repository at this point in the history

  7. Fix title underline length in whatisnew doc. 

    Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
    @stroxler
    stroxler committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    42277cb View commit details
    Browse the repository at this point in the history

  8. Update Misc/NEWS.d/next/Library/2023-02-04-16-35-46.gh-issue-101561.X… 

    …o6pIZ.rst

Co-authored-by: Alex Waygood <[email protected]>
    @stroxler @AlexWaygood
    stroxler and AlexWaygood committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    afb74de View commit details
    Browse the repository at this point in the history

  9. Use a positional-only argument named method 

    Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
    @stroxler
    stroxler committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    090d9d2 View commit details
    Browse the repository at this point in the history

  10. Apply suggestions from code review 

    Thanks, looks good

Co-authored-by: Jelle Zijlstra <[email protected]>
    @stroxler @JelleZijlstra
    stroxler and JelleZijlstra authored Feb 27, 2023
    Configuration menu
    Copy the full SHA
    f6c00e5 View commit details
    Browse the repository at this point in the history