Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-84559: Change the multiprocessing start method default to forkserver #101556

Merged
merged 14 commits into from
Sep 26, 2024
Merged

gh-84559: Change the multiprocessing start method default to forkserver #101556

merged 14 commits into from
Sep 26, 2024

Conversation

gpshead
Copy link
Member

@gpshead gpshead commented Feb 4, 2023 •
edited
Loading

We change the default from fork to forkserver or spawn. See the issue for details.

This change is intended for Python 3.14.

TODO:

  • The 3.13 release branch has been made, thus starting 3.14 in main.
  • NEWS entry added.
  • Documentation updates in:
    • library/multiprocessing.rst
    • library/concurrent.futures.rst
    • whatsnew/3.14.rst

@gpshead
pythongh-84559: Change the default multiprocessing start method.
c5277b7 
We drop 'fork' in favor of 'forkserver' or 'spawn'. See the issue for details.
@bedevere-bot bedevere-bot mentioned this pull request Feb 4, 2023
Closed
@gpshead gpshead self-assigned this Sep 12, 2023
@gpshead gpshead marked this pull request as ready for review September 24, 2024 21:24
@gpshead gpshead requested a review from hugovk September 24, 2024 21:25
@gpshead gpshead changed the title gh-84559: multiprocessing start method default away from fork gh-84559: Change the multiprocessing start method default to forkserver Sep 24, 2024
@gpshead gpshead added 3.14 new features, bugs and security fixes docs Documentation in the Doc dir stdlib Python modules in the Lib dir and removed DO-NOT-MERGE labels Sep 24, 2024
@gpshead
Copy link
Member Author

gpshead commented Sep 25, 2024

@ericsnowcurrently could you review? (likely an easy one)

ericsnowcurrently
ericsnowcurrently approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for following this through!

Lib/test/support/__init__.py Show resolved Hide resolved
Lib/test/_test_multiprocessing.py Show resolved Hide resolved
@gpshead gpshead added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 26, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @gpshead for commit 668559c 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 26, 2024
@gpshead gpshead merged commit b65f2cd into python:main Sep 26, 2024
87 of 92 checks passed
@gpshead gpshead deleted the multiprocessing/default-start-method-3.14 branch September 26, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk left review comments

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees

@gpshead gpshead

Labels
3.14 new features, bugs and security fixes docs Documentation in the Doc dir stdlib Python modules in the Lib dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gpshead @bedevere-bot @ericsnowcurrently @hugovk