Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-73435: Implement recursive wildcards in pathlib.PurePath.match() #101398

Merged
merged 40 commits into from
May 30, 2023
Merged

GH-73435: Implement recursive wildcards in pathlib.PurePath.match() #101398

merged 40 commits into from
May 30, 2023

Commits on Jan 28, 2023

  1. pythongh-73435: Implement recursive wildcards in pathlib.PurePath.mat… 

    …ch()

Add a new *recursive* argument to `pathlib.PurePath.match()`, defaulting
to `False`. If set to true, `match()` handles the `**` wildcard as in
`Path.glob()`, i.e. it matches any number of path segments.

We now compile a `re.Pattern` object for the entire pattern. This is made
more difficult by `fnmatch` not treating directory separators as special
when evaluating wildcards (`*`, `?`, etc), and so we arrange the path parts
onto separate *lines* in a string, and ensure we don't set `re.DOTALL`.
    @barneygale
    barneygale committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    608e917 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2023

  1. Simplify code slightly

    @barneygale
    barneygale committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    9a43c7f View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. Fix support for newlines

    @barneygale
    barneygale committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    a846279 View commit details
    Browse the repository at this point in the history

  2. Cache translation of individual components

    @barneygale
    barneygale committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    bbd8cd6 View commit details
    Browse the repository at this point in the history

  3. Drop 'recursive' argument, make this the only behaviour.

    @barneygale
    barneygale committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    b5c002e View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. Undo modifications to fnmatch.py

    @barneygale
    barneygale committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    0afcd54 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. Merge branch 'main' into pythongh-73435-pathlib-match-recursive

    @barneygale
    barneygale committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    fe32717 View commit details
    Browse the repository at this point in the history

  2. Fix Windows support

    @barneygale
    barneygale committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    7b6f850 View commit details
    Browse the repository at this point in the history

  3. Tidy up code.

    @barneygale
    barneygale committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    037488a View commit details
    Browse the repository at this point in the history

  4. Add news blurb.

    @barneygale
    barneygale committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    0741950 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. Merge branch 'main' into pythongh-73435-pathlib-match-recursive

    @barneygale
    barneygale authored Feb 20, 2023
    Configuration menu
    Copy the full SHA
    e1c9731 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. Merge branch 'main' into pythongh-73435-pathlib-match-recursive

    @barneygale
    barneygale committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    db6f0ad View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2023

  1. Merge branch 'main' into pythongh-73435-pathlib-match-recursive

    @barneygale
    barneygale committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    8dff9e2 View commit details
    Browse the repository at this point in the history

  2. Simplify patch; prepare for use in glob()

    @barneygale
    barneygale committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    314679f View commit details
    Browse the repository at this point in the history

  3. Make better use of path object caching.

    @barneygale
    barneygale committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    90eebcc View commit details
    Browse the repository at this point in the history

  4. Add performance tip to docs

    @barneygale
    barneygale committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    4b5fffd View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Skip re-initialisation of PurePath patterns.

    @barneygale
    barneygale committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    5e8bc28 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2023

  1. Merge branch 'main' into pythongh-73435-pathlib-match-recursive

    @barneygale
    barneygale authored Apr 29, 2023
    Configuration menu
    Copy the full SHA
    e81ab5a View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. Merge branch 'main' into pythongh-73435-pathlib-match-recursive

    @barneygale
    barneygale committed May 2, 2023
    Configuration menu
    Copy the full SHA
    afb8047 View commit details
    Browse the repository at this point in the history

  2. Use re.IGNORECASE rather than os.path.normcase()

    @barneygale
    barneygale committed May 2, 2023
    Configuration menu
    Copy the full SHA
    722a1ab View commit details
    Browse the repository at this point in the history

Commits on May 6, 2023

  1. Merge branch 'main' into pythongh-73435-pathlib-match-recursive

    @barneygale
    barneygale committed May 6, 2023
    Configuration menu
    Copy the full SHA
    0ccf3df View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Add whats new entry

    @barneygale
    barneygale committed May 11, 2023
    Configuration menu
    Copy the full SHA
    ccea5e1 View commit details
    Browse the repository at this point in the history

  2. Update Doc/whatsnew/3.12.rst 

    Co-authored-by: Hugo van Kemenade <[email protected]>
    @barneygale @hugovk
    barneygale and hugovk authored May 11, 2023
    Configuration menu
    Copy the full SHA
    dd04294 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Alex Waygood <[email protected]>
    @barneygale @AlexWaygood
    barneygale and AlexWaygood authored May 14, 2023
    Configuration menu
    Copy the full SHA
    b258641 View commit details
    Browse the repository at this point in the history

  2. Explain _FNMATCH_SLICE

    @barneygale
    barneygale committed May 14, 2023
    Configuration menu
    Copy the full SHA
    ced8998 View commit details
    Browse the repository at this point in the history

  3. Accidentally a word.

    @barneygale
    barneygale committed May 14, 2023
    Configuration menu
    Copy the full SHA
    a33c7b6 View commit details
    Browse the repository at this point in the history

  4. Cache pattern compilation

    @barneygale
    barneygale committed May 14, 2023
    Configuration menu
    Copy the full SHA
    4b3bddb View commit details
    Browse the repository at this point in the history

  5. Remove unneeded from None suffix, whoops.

    @barneygale
    barneygale committed May 14, 2023
    Configuration menu
    Copy the full SHA
    6ad30dd View commit details
    Browse the repository at this point in the history

  6. Tiny performance improvement: avoid accessing path.parts

    @barneygale
    barneygale committed May 14, 2023
    Configuration menu
    Copy the full SHA
    052890f View commit details
    Browse the repository at this point in the history

  7. Typo fix

    @barneygale
    barneygale committed May 14, 2023
    Configuration menu
    Copy the full SHA
    d789b6d View commit details
    Browse the repository at this point in the history

  8. Avoid hashing path object when compiling pattern.

    @barneygale
    barneygale committed May 14, 2023
    Configuration menu
    Copy the full SHA
    4fe77c6 View commit details
    Browse the repository at this point in the history

  9. More performance tweaks

    @barneygale
    barneygale committed May 14, 2023
    Configuration menu
    Copy the full SHA
    4770c13 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Merge branch 'main' into pythongh-73435-pathlib-match-recursive

    @barneygale
    barneygale committed May 18, 2023
    Configuration menu
    Copy the full SHA
    559787d View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Merge branch 'main' into pythongh-73435-pathlib-match-recursive

    @barneygale
    barneygale committed May 23, 2023
    Configuration menu
    Copy the full SHA
    9c09fc4 View commit details
    Browse the repository at this point in the history

  2. Re-target to 3.13.

    @barneygale
    barneygale committed May 23, 2023
    Configuration menu
    Copy the full SHA
    eb35dbc View commit details
    Browse the repository at this point in the history

Commits on May 27, 2023

  1. Merge branch 'main' into pythongh-73435-pathlib-match-recursive

    @barneygale
    barneygale authored May 27, 2023
    Configuration menu
    Copy the full SHA
    8959dfd View commit details
    Browse the repository at this point in the history

Commits on May 29, 2023

  1. Merge branch 'main' into pythongh-73435-pathlib-match-recursive

    @barneygale
    barneygale committed May 29, 2023
    Configuration menu
    Copy the full SHA
    fec7702 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into pythongh-73435-pathlib-match-recursive

    @barneygale
    barneygale authored May 29, 2023
    Configuration menu
    Copy the full SHA
    89bc380 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Add more comments!

    @barneygale
    barneygale committed May 30, 2023
    Configuration menu
    Copy the full SHA
    9211297 View commit details
    Browse the repository at this point in the history

  2. Update Lib/pathlib.py 

    Co-authored-by: Alex Waygood <[email protected]>
    @barneygale @AlexWaygood
    barneygale and AlexWaygood authored May 30, 2023
    Configuration menu
    Copy the full SHA
    73bb309 View commit details
    Browse the repository at this point in the history