Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-59956: Allow the "Trashcan" Mechanism to Work Without a Thread State #101209

Merged
merged 2 commits into from
Jan 23, 2023
Merged

gh-59956: Allow the "Trashcan" Mechanism to Work Without a Thread State #101209

merged 2 commits into from
Jan 23, 2023

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Jan 21, 2023 •
edited by bedevere-bot
Loading

We've factored out a struct from the two PyThreadState fields. This accomplishes two things:

  • make it clear that the trashcan-related code doesn't need any other parts of PyThreadState
  • allows us to use the trashcan mechanism even when there isn't a "current" thread state

We still expect the caller to hold the GIL.

@bedevere-bot bedevere-bot mentioned this pull request Jan 21, 2023
Open
@ericsnowcurrently ericsnowcurrently merged commit 7b20a0f into python:main Jan 23, 2023
@ericsnowcurrently ericsnowcurrently deleted the trashcan-struct branch January 23, 2023 15:30
@tacaswell tacaswell mentioned this pull request Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericsnowcurrently @bedevere-bot