Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-100676: Improve description for venv --upgrade-deps (GH-100678) #100678

Merged
merged 6 commits into from
Jan 2, 2023
Merged

gh-100676: Improve description for venv --upgrade-deps (GH-100678) #100678

merged 6 commits into from
Jan 2, 2023

Conversation

rblcoder
Copy link
Contributor

@rblcoder rblcoder commented Jan 2, 2023

Replace ", ".join() in " ".join(CORE_VENV_DEPS)}

Improve description for venv --upgrade-deps #100676
@rblcoder rblcoder requested a review from vsajip as a code owner January 2, 2023 05:54
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Jan 2, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@rblcoder rblcoder changed the title #100676 gh-100676 Jan 2, 2023
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@AlexWaygood AlexWaygood changed the title gh-100676 gh-100676: Improve description for venv --upgrade-deps Jan 2, 2023
Copy link
Member

@vsajip vsajip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the skip_news label, so the NEWS entry isn't needed. Please remove it from the PR.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

@rblcoder
Copy link
Contributor Author

rblcoder commented Jan 2, 2023

I've added the skip_news label, so the NEWS entry isn't needed. Please remove it from the PR.

I have made the requested changes; please review again.

@kumaraditya303 kumaraditya303 linked an issue Jan 2, 2023 that may be closed by this pull request
@vsajip vsajip changed the title gh-100676: Improve description for venv --upgrade-deps gh-100676: Improve description for venv --upgrade-deps (GH-100678) Jan 2, 2023
@vsajip vsajip merged commit 9dee973 into python:main Jan 2, 2023
@vsajip vsajip added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jan 2, 2023
@miss-islington
Copy link
Contributor

Thanks @rblcoder for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @rblcoder for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @rblcoder and @vsajip, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9dee9731663d670652586c929190f227ab56bd8f 3.11

@miss-islington
Copy link
Contributor

Sorry @rblcoder and @vsajip, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 9dee9731663d670652586c929190f227ab56bd8f 3.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve description for venv --upgrade-deps
5 participants